chore: allow SDK prerelease roll-forward in global.json by ANcpLua · Pull Request #162 · ANcpLua/ANcpLua.NET.Sdk

ANcpLua · 2026-05-16T04:08:31Z

Summary

Add allowPrerelease: true under sdk in global.json to match the template used across the other published-package repos (dotcov, ErrorOrX, qyl, ANcpLua.Agents, ANcpLua.Analyzers, ANcpLua.Roslyn.Utilities).
Lets the SDK roll forward to 10.0.4xx-preview automatically when it lands. No behavioral change on stable 10.0.300.

Test plan

CI green
dotnet --info still resolves 10.0.300 locally

🤖 Generated with Claude Code

Summary by CodeRabbit

Chores
- Refactored CI/CD pipeline configuration to reference SDK version settings from the project configuration file instead of hardcoding values.
- Enabled prerelease version support for SDK tools used in building and testing.

Aligns with the template used across the other published-package repos (dotcov, ErrorOrX, qyl, ANcpLua.Agents, ANcpLua.Analyzers, ANcpLua.Roslyn.Utilities) so 10.0.4xx-preview can be picked up automatically when it lands. No behavioral change on stable 10.0.300. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-05-16T04:08:41Z

@coderabbitai autofix

coderabbitai · 2026-05-16T04:08:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 62676554-2737-42dd-a4eb-35e2a31448f6

📥 Commits

Reviewing files that changed from the base of the PR and between fcaec96 and 39179cb.

📒 Files selected for processing (2)

.github/workflows/nuget-publish.yml
global.json

📜 Recent review details

⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: create_nuget
GitHub Check: copilot-pull-request-reviewer
GitHub Check: Codacy Static Code Analysis
GitHub Check: claude-review
GitHub Check: lint_config

🧰 Additional context used

📓 Path-based instructions (2)

global.json

📄 CodeRabbit inference engine (AGENTS.md)

Declare global.json msbuild-sdks entries for all ANcpLua SDK variants used in the solution

Files:

global.json

.github/workflows/**

⚙️ CodeRabbit configuration file

.github/workflows/**: Pin third-party actions to SHA. First-party (actions/*) tag-pin OK.
Concurrency groups required on push-triggered workflows.
Secrets via env: not inline. No secrets in logs.
Minimal permissions per job.
Pattern A release: changes to compute_version logic affect every push to
main — flag carefully.

Files:

.github/workflows/nuget-publish.yml

🔇 Additional comments (2)

.github/workflows/nuget-publish.yml (1)

33-33: LGTM!

Also applies to: 112-112, 142-142, 178-178

global.json (1)

4-5: LGTM!

📝 Walkthrough

Walkthrough

The PR consolidates .NET SDK version management from four hardcoded workflow job configurations into a single global.json source of truth. The nuget-publish.yml workflow jobs (lint_config, create_nuget, test, deploy) replace dotnet-version: '10.0.x' inputs with global-json-file: global.json. The global.json file adds allowPrerelease: true to permit prerelease SDK versions while retaining the pinned version 10.0.300.

🚥 Pre-merge checks | ✅ 8

✅ Passed checks (8 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title follows conventional commits format (chore prefix), is under 72 characters (55 chars), contains no trailing period, and accurately describes the main change of enabling prerelease SDK versions in global.json.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No Datetime.Now/Utcnow	✅ Passed	No C# files modified in PR. Changes limited to .github/workflows/nuget-publish.yml (YAML) and global.json (JSON). Custom check for DateTime.Now/UtcNow is not applicable.
No .Result/.Wait() Blocking Async	✅ Passed	PR modifies only non-C# files (.github/workflows/nuget-publish.yml [YAML] and global.json [JSON]). Custom check targets C# files only, so it's not applicable.
No Null-Forgiving Operator Without Justification	✅ Passed	No C# files modified in this PR. Changes are YAML workflow and JSON config only. Check applies only to C# files.
No Suppression Of Fixable Diagnostics	✅ Passed	No C# files added or modified. PR changes only `.github/workflows/nuget-publish.yml` (YAML) and `global.json` (JSON). Check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

claude · 2026-05-16T04:08:47Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

coderabbitai · 2026-05-16T04:08:47Z

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

codacy-production · 2026-05-16T04:08:53Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

codacy-production

Pull Request Overview

The pull request successfully updates the repository to use global-json-based SDK resolution in GitHub Actions, which simplifies version management. However, the specified SDK version '10.0.300' in global.json is too restrictive. Since .NET 10 is currently in early preview, it typically uses the '10.0.100' feature band. Using '300' alongside the 'latestFeature' roll-forward policy will prevent the SDK from being found on agents that only have standard preview installs. This issue should be resolved before merging to prevent CI failures.

Test suggestions

Verify global.json contains the allowPrerelease flag set to true
Verify GitHub Action jobs (lint_config, create_nuget, test, deploy) use the global-json-file parameter
Verify SDK resolution in CI via the dotnet --info command

_{TIP Improve review quality by adding custom instructions}
_{TIP How was this review? Give us feedback}

codacy-production · 2026-05-16T04:10:07Z

  "sdk": {
    "rollForward": "latestFeature",
-    "version": "10.0.300"
+    "version": "10.0.300",


_{🔴 HIGH RISK}

The SDK version '10.0.300' might be too restrictive. Since .NET 10 is in early preview, using the base feature band '10.0.100' is recommended to ensure the 'latestFeature' policy can successfully find available SDKs.

Suggested change

"version": "10.0.300",

"version": "10.0.100",

Copilot

Pull request overview

Adds prerelease SDK roll-forward support and updates CI SDK setup to read from global.json.

Changes:

Enables allowPrerelease in root global.json.
Switches NuGet publish workflow setup-dotnet steps from 10.0.x to global-json-file.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
`global.json`	Allows prerelease SDKs during roll-forward resolution.
`.github/workflows/nuget-publish.yml`	Updates CI SDK installation to use the repository `global.json`.

      - uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5
        with:
-          dotnet-version: '10.0.x'
+          global-json-file: global.json


      - uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5
        with:
-          dotnet-version: '10.0.x'
+          global-json-file: global.json


      - uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5
        with:
-          dotnet-version: '10.0.x'
+          global-json-file: global.json


      - uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5
        with:
-          dotnet-version: '10.0.x'
+          global-json-file: global.json


ANcpLua and others added 2 commits May 16, 2026 05:44

fix(ci): install dotnet from global json

f629a27

Copilot AI review requested due to automatic review settings May 16, 2026 04:08

github-actions Bot enabled auto-merge (squash) May 16, 2026 04:08

Copilot started reviewing on behalf of ANcpLua May 16, 2026 04:08 View session

codacy-production Bot reviewed May 16, 2026

View reviewed changes

Copilot AI reviewed May 16, 2026

View reviewed changes

github-actions Bot merged commit fde64bb into main May 16, 2026
15 checks passed

ANcpLua deleted the codex/pin-dotnet-global-json branch May 16, 2026 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: allow SDK prerelease roll-forward in global.json#162

chore: allow SDK prerelease roll-forward in global.json#162
github-actions[bot] merged 2 commits into
mainfrom
codex/pin-dotnet-global-json

ANcpLua commented May 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026 •

edited

Loading

Walkthrough

Uh oh!

claude Bot commented May 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 16, 2026

Uh oh!

codacy-production Bot commented May 16, 2026

Uh oh!

codacy-production Bot left a comment

Uh oh!

codacy-production Bot May 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ANcpLua commented May 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

claude Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 16, 2026

Uh oh!

codacy-production Bot commented May 16, 2026

Up to standards ✅

Uh oh!

codacy-production Bot left a comment

Choose a reason for hiding this comment

Pull Request Overview

Test suggestions

Uh oh!

codacy-production Bot May 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ANcpLua commented May 16, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 16, 2026 •

edited

Loading

claude Bot commented May 16, 2026 •

edited

Loading