You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the ANcpLua.NET.Sdk.BitNet SDK variant entirely. Consumers wanting BitNet hosting just take a plain <PackageReference Include="ANcpLua.Agents.Hosting.BitNet" /> against ANcpLua.NET.Sdk (or .Web).
Why
The variant earned one line saved over a plain PackageReference (the implicit injection in GlobalPackages.props), plus one warning code (ANCPLBITNET001) that only existed because of the SDK. For an alpha-channel feature the NuGet package has 0 dependents on, the carrying cost — separate csproj/nuspec/Sdk.props/Sdk.targets/editorconfig, a Version.props pin to keep in lockstep with ANcpLua/ANcpLua.Agents releases, generator+packer awareness — was higher than the value.
The user will deprecate the existing ANcpLua.NET.Sdk.BitNet NuGet package separately.
What's gone
Deleted (5 files):
src/ANcpLua.NET.Sdk.BitNet.csproj
src/ANcpLua.NET.Sdk.BitNet.nuspec
src/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.props
src/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.targets
src/Config/ANcpLua.NET.Sdk.BitNet.editorconfig
Edited (6 files):
ANcpLua.NET.Sdk.slnx — remove project entry
README.md — drop .BitNet entry from the global.json block, the <Project Sdk="ANcpLua.NET.Sdk.BitNet"> example, and the entire "BitNet variant — what it adds" section
tools/SdkGenerator/Program.cs — remove the .BitNet tuple from the generator's sdks[] (so re-running the generator doesn't recreate the deleted Sdk.props/Sdk.targets)
src/Build/Common/Version.props — drop the <PropertyGroup Label="BitNet Hosting"> with ANcpLuaAgentsHostingBitNetVersion
src/Build/Common/GlobalPackages.props — drop the conditional ItemGroup that auto-injected ANcpLua.Agents.Hosting.BitNet
(Version pinned in the consumer's Directory.Packages.props under CPM, which the SDK still enforces.)
Companion PR
ANcpLua/ANcpLua.Agents#… — strips the matching "Zero-ceremony path — ANcpLua.NET.Sdk.BitNet" section from the Hosting.BitNet README.
Test plan
CI green: lint_config, create_nuget (no longer packs the .BitNet nupkg), test matrix on ubuntu/windows/macos, deploy to NuGet on main merge.
dotnet run --project tools/SdkGenerator produces no .BitNet artifacts.
Consumer with plain ANcpLua.NET.Sdk + <PackageReference Include="ANcpLua.Agents.Hosting.BitNet" /> still resolves and calls builder.AddQylBitNetChatClient().
Drops every reference to the .BitNet SDK variant from build config,
generator, version pins, package auto-injection, README, and the
solution file. Companion commits delete the .BitNet csproj/nuspec/
Sdk.props/Sdk.targets/editorconfig.
Rationale: the variant saved one PackageReference line over plain
`ANcpLua.NET.Sdk` + `<PackageReference Include="ANcpLua.Agents.Hosting.BitNet" />`
and added a warning code that only existed because of the SDK. Not
worth its surface area; consumers should just take the package
reference directly.
The .BitNet NuGet package is unused (0 dependents on nuget.org) and
will be deprecated separately.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4eaf5af0-4e0d-4155-9533-9c6adabe922f
📥 Commits
Reviewing files that changed from the base of the PR and between 6ea47dd and d8b3b64.
📒 Files selected for processing (1)
tools/verify-templates.ps1
📜 Recent review details⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Use CRLF (Windows-style) line endings for Windows batch and PowerShell scripts
Files:
tools/verify-templates.ps1
tools/**
⚙️ CodeRabbit configuration file
tools/**: Internal tooling — config file generators, build helpers. Lower bar than
production src/, but still flag obvious bugs (missing null check that
crashes the build, hardcoded paths, swallowed exceptions).
Files:
tools/verify-templates.ps1
🧠 Learnings (1)📓 Common learnings
Learnt from: CR
Repo: ANcpLua/ANcpLua.NET.Sdk
Timestamp: 2026-05-18T01:09:52.949Z
Learning: Use `ANcpLua.NET.Sdk` MSBuild SDK for Library, Console, and Worker projects
Learnt from: CR
Repo: ANcpLua/ANcpLua.NET.Sdk
Timestamp: 2026-05-18T01:09:52.949Z
Learning: Use `ANcpLua.NET.Sdk.Web` MSBuild SDK for Web API projects
Learnt from: CR
Repo: ANcpLua/ANcpLua.NET.Sdk
Timestamp: 2026-05-18T01:09:52.949Z
Learning: Use `ANcpLua.NET.Sdk.Test` MSBuild SDK for Test projects
tests/ANcpLua.Agents.Tests/Packaging/PackageBoundaryTests.cs — lists "ANcpLua.Agents.Hosting.BitNet" in package boundary expectations. [::ANcpLua/ANcpLua.Agents::]
Hosting package and generator consumers:
src/ANcpLua.Agents.Hosting.BitNet/Facades/QylBitNetHostingExtensions.cs — builder.AddQylBitNetChatClient overloads (call sites consumers will use). [::ANcpLua/ANcpLua.Agents::]
src/ANcpLua.Agents.Hosting.BitNet/Factory/QylBitNetChatClientFactory.cs — factory used by hosting extension. [::ANcpLua/ANcpLua.Agents::]
src/ANcpLua.Agents.Hosting.BitNet.Generators/QylBitNetEndpointGenerator.cs — source generator that emits AddDiscoveredQylBitNetClients which calls AddQylBitNetChatClient. (Generator ties implicit wiring to package API.) [::ANcpLua/ANcpLua.Agents::]
Packaging/publish workflow:
.github/workflows/nuget-publish.yml — dotnet pack step for ANcpLua.Agents.Hosting.BitNet referenced (CI/publish must be updated if packaging changes). [::ANcpLua/ANcpLua.Agents::]
Documentation/zero‑ceremony note:
src/ANcpLua.Agents.Hosting.BitNet/README.md — documents implicit PackageReference via ANcpLua.NET.Sdk.BitNet (global.json example and ). Removal of SDK variant requires consumers to add explicit PackageReference. [::ANcpLua/ANcpLua.Agents::]
ANcpLua/ANcpLua.Roslyn.Utilities
Test helpers referencing BitNet:
src/ANcpLua.Roslyn.Utilities.Testing/AI/BitNetFixture.cs — BitNetFixture xUnit fixture exposing IChatClient for live BitNet tests. [::ANcpLua/ANcpLua.Roslyn.Utilities::]
src/ANcpLua.Roslyn.Utilities.Testing/AI/BitNetCollection.cs — BitNet test collection/attribute for tests requiring the fixture. [::ANcpLua/ANcpLua.Roslyn.Utilities::]
README notes live-LLM integration and BitNet fixture. [::ANcpLua/ANcpLua.Roslyn.Utilities::]
Other repositories searched (no matches for "BitNet")
ANcpLua/ANcpLua.Analyzers — no hits. [::ANcpLua/ANcpLua.Analyzers::]
O-ANcppLua/ANcpLua.OtelConventions.Api — no hits. [::O-ANcppLua/ANcpLua.OtelConventions.Api::]
O-ANcppLua/Nuke.OpenTelemetry.Conventions — no hits. [::O-ANcppLua/Nuke.OpenTelemetry.Conventions::]
ANcpLua/ErrorOrX — no hits. [::ANcpLua/ErrorOrX::]
ANcpLua/dotcov — no hits. [::ANcpLua/dotcov::]
ANcpLua/Arqio — no hits. [::ANcpLua/Arqio::]
ANcpLua/safe-autoresearch — no hits. [::ANcpLua/safe-autoresearch::]
ANcpLua/typespec-otel-semconv — no hits. [::ANcpLua/typespec-otel-semconv::]
Summary implication
ANcpLua.Agents and ANcpLua.Roslyn.Utilities contain tests, source generators, hosting extensions, and documentation that rely on the ANcpLua.Agents.Hosting.BitNet package and the former zero‑ceremony SDK variant. The PR’s removal of ANcpLua.NET.Sdk.BitNet means affected consumers must add explicit (and ensure versioning via Directory.Packages.props/CPM) and update packaging/CI expectations that previously relied on the SDK variant/Version.props injection. [::ANcpLua/ANcpLua.Agents::] [::ANcpLua/ANcpLua.Roslyn.Utilities::]
🔇 Additional comments (2)
tools/verify-templates.ps1 (2)
9-9: LGTM!
Also applies to: 88-90
108-113: LGTM!
Behavioral Changes
Removes ANcpLua.NET.Sdk.BitNet SDK variant entirely. Projects using Sdk="ANcpLua.NET.Sdk.BitNet" must migrate to:
Sdk="ANcpLua.NET.Sdk"
explicit <PackageReference Include="ANcpLua.Agents.Hosting.BitNet" /> with version pinned via Directory.Packages.props or CPM
Deleted 5 files (csproj, nuspec, two Sdk.{props,targets}, editorconfig) and 6 edited files across solution, build tooling, and configuration:
Solution file: removed project entry
build.ps1: removed dotnet pack for .BitNet project
SdkGenerator: removed .BitNet from sdks array to prevent regeneration of deleted SDK artifacts
GlobalPackages.props: removed conditional ItemGroup that auto-injected ANcpLua.Agents.Hosting.BitNet
README: removed global.json example, Project Sdk example, and "BitNet variant" section
verify-templates.ps1: adjusted expected artifact count from 5 to 4 nupkgs
Risk Surface
Breaking change for projects consuming ANcpLua.NET.Sdk.BitNet, though PR states 0 NuGet dependents (variant provided only implicit PackageReference convenience and warning ANCPLBITNET001). Migration path documented in README removal.
Validation Evidence
CI gates updated: verify-templates.ps1 Gate 2 expects 4 nupkgs instead of 5, removed ANcpLua.NET.Sdk.BitNet.$Version.nupkg from expected-artifacts list
SdkGenerator producing no .BitNet artifacts confirmed by code removal
Consumer resolution tested: builder.AddQylBitNetChatClient() works with plain SDK + explicit PackageReference
Standard CI pipeline passes (lint_config, create_nuget, test matrix, deploy)
Generated Artifacts
Build output changes from 5 to 4 NuGet packages: SDK, SDK.Web, SDK.Test, Templates (removes SDK.BitNet).
Cross-Repo Implications
Companion PR in ANcpLua/ANcpLua.Agents repo removes matching README section. Separate NuGet package ANcpLua.Agents.Hosting.BitNet will be deprecated in follow-up.
Walkthrough
This PR removes the ANcpLua.NET.Sdk.BitNet SDK variant and all related artifacts: solution registration, project and nuspec contents, MSBuild props/targets and version/property wiring, packaging/pack expectations, SDK generation, template verification, README examples, and BitNet editorconfig entries.
Changes
BitNet SDK Variant Removal
Layer / File(s)
Summary
Solution registration and SDK generator cleanup ANcpLua.NET.Sdk.slnx, tools/SdkGenerator/Program.cs
BitNet project removed from solution; SDK generator array no longer lists ANcpLua.NET.Sdk.BitNet, so generator skips creating BitNet Sdk.props/Sdk.targets.
Project, nuspec and packaging removal src/ANcpLua.NET.Sdk.BitNet.csproj, src/ANcpLua.NET.Sdk.BitNet.nuspec, build.ps1, tools/verify-templates.ps1
BitNet project and nuspec contents deleted; dotnet pack invocation for BitNet removed; template verification expectations updated to expect 4 nupkgs and omit BitNet package.
MSBuild props/targets and auto-injection cleanup src/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.props, src/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.targets, src/Build/Common/GlobalPackages.props, src/Build/Common/Version.props, tools/verify-templates.ps1
Removed BitNet-specific Sdk.props/Sdk.targets content, deleted conditional ItemGroup that auto-injected ANcpLua.Agents.Hosting.BitNet, and removed ANcpLuaAgentsHostingBitNetVersion property.
Docs and editorconfig cleanup README.md, src/Config/ANcpLua.NET.Sdk.BitNet.editorconfig
Removed BitNet entries from global.json example, Project examples, and the "BitNet variant" documentation section; removed BitNet editorconfig global diagnostic and CA1002 suppression.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
ANcpLua/ANcpLua.NET.Sdk#143: Original PR that introduced BitNet SDK registration across the same files now being removed.
ANcpLua/ANcpLua.Agents#90: Adds documentation for the BitNet implicit hosting injection; this PR removes that implicit path.
Please resolve all errors before merging. Addressing warnings is optional.
Ignore
❌ Failed checks (2 errors, 1 warning)
Check name
Status
Explanation
Resolution
Public Contract Documented
❌ Error
PR removes public SDK variant ANcpLua.NET.Sdk.BitNet without explicit breaking change documentation. README removed .BitNet examples but added no migration guide or compatibility notes.
Add breaking change section to README or create CHANGELOG documenting SDK removal, required migration (base SDK + explicit PackageReference), and consumer impact.
No Datetime.Now/Utcnow
❌ Error
Found 4 instances of DateTime.Now in added test files. All are in fixtures testing the ban mechanism, but lack explicit inline comments as required by the check.
Add inline comments at each DateTime.Now usage explaining it tests the ban mechanism. Example: // Test: verify DateTime.Now produces RS0030 warning
Tests Match Risk
⚠️ Warning
Implicit BitNet PackageReference injection removed without focused tests validating the new explicit-reference consumer contract works correctly for the declared migration path.
Add integration test confirming projects with plain SDK + explicit ANcpLua.Agents.Hosting.BitNet PackageReference can resolve builder.AddQylBitNetChatClient(). Verify companion PR properly deprecates the BitNet NuGet package.
✅ Passed checks (16 passed)
Check name
Status
Explanation
Title check
✅ Passed
Title follows conventional commits format with 'chore' scope, under 72 characters (48), uses exact summary 'remove ANcpLua.NET.Sdk.BitNet SDK variant' naming the highest-impact change, no trailing punctuation.
Description check
✅ Passed
Description precisely aligns with changeset: explains removal rationale, lists all deleted/edited files, provides consumer migration path, test plan, and companion PR reference.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
No Secrets Or Pii
✅ Passed
PR removes BitNet SDK variant with no secrets, tokens, credentials, API keys, connection strings, or PII added. All changes are deletions and cleanup of build/config files.
Generated Files Regenerated
✅ Passed
SdkGenerator input removed BitNet entry. Generated files (Sdk.props/Sdk.targets) correctly deleted for BitNet, present for remaining 3 SDK variants with proper format. No hand-edits detected.
Async And Cancellation Safe
✅ Passed
PR removes BitNet SDK. Only synchronous code changes; no async boundaries, tokens, or fire-and-forget work introduced.
Ci Release Safety
✅ Passed
No GitHub Actions workflows modified. Build scripts only adjusted for SDK removal. No validation jobs, security controls, or permissions affected.
No Copy Paste Tables
✅ Passed
PR removes BitNet SDK variant without introducing problematic copy-paste patterns. Remaining structures use appropriate data-driven designs.
No Hidden Fallback Path
✅ Passed
Removes hidden auto-injection fallback pattern. No new catch blocks, wrappers, defaults, or silent failures introduced. Consumer deps now explicit.
Observability Boundary
✅ Passed
Check not applicable. PR removes BitNet SDK build infrastructure only—no new services, jobs, queues, clients, storage writers, MCP tools, or workflows are introduced.
Dependency Hygiene
✅ Passed
PR cleanly removes BitNet variant with no new dependency additions, no version pin drift, proper orphaned reference cleanup, and maintained build convention hygiene.
No .Result/.Wait() Blocking Async
✅ Passed
Single modified C# file: tools/SdkGenerator/Program.cs. Change: removed BitNet SDK array entry. No blocking async patterns (.Result, .Wait, GetAwaiter().GetResult).
No Null-Forgiving Operator
✅ Passed
No null-forgiving operators found in any added/modified C# files. All 18 modified .cs files scanned comprehensively; no ! null-forgiving operators detected.
No Suppression Of Fixable Diagnostics
✅ Passed
No pragma or SuppressMessage attributes were added. Only tools/SdkGenerator/Program.cs was modified, with a single line removed (BitNet entry) containing no suppressions.
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch claude/bitnet-extension-abstraction-XuaCv
✨ Simplify code
Create PR with simplified code
Commit simplified code in branch claude/bitnet-extension-abstraction-XuaCv
🛠️ architecture hardening
🛠️ security pass
🛠️ test gap closure
🛠️ docs and changelog alignment
🛠️ performance and allocation pass
Comment @coderabbitai help to get the list of available commands and usage tips.
The reason will be displayed to describe this comment to others. Learn more.
Keep template verifier aligned with packed SDK set
Removing the BitNet dotnet pack call makes tools/verify-templates.ps1 fail every time at Gate 2, because it still requires ANcpLua.NET.Sdk.BitNet.$Version.nupkg in its expected artifact list (lines 108–113 in that script). In practice, anyone running that verifier after this change will get a false failure even when packaging is otherwise correct, so this change should include the matching verifier update.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR successfully removes the BitNet SDK variant across the repository. The changes correctly delete the project-specific files, update the SDK generator, remove implicit package injections, and clean up documentation.
Codacy analysis reports that the changes are up to standards with no new issues or quality regressions. All defined acceptance criteria for the removal have been met, effectively reducing the maintenance overhead as intended.
Test suggestions
Verify build.ps1 no longer attempts to pack the removed BitNet project.
Verify SdkGenerator excludes the BitNet variant from its generation list.
Verify GlobalPackages.props no longer contains implicit package injection for BitNet.
Verify documentation (README.md) reflects the removal and provides no legacy examples.
Codex flagged that tools/verify-templates.ps1 still requires
ANcpLua.NET.Sdk.BitNet.$Version.nupkg in its Gate 2 expected-artifacts
list, so every verifier run after the .BitNet removal would fail with
"missing from artifacts/" even when packaging is otherwise correct.
Drop the .BitNet entry and update the "all 5 nupkgs" wording in both
the docstring and the Gate 2 Write-Step header to "all 4 nupkgs".
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
1-66: 🧹 Nitpick | 🔵 Trivial
Coordinate companion PR merge to prevent documentation drift.
The linked ANcpLua.Agents repository documents the BitNet SDK variant in src/ANcpLua.Agents.Hosting.BitNet/README.md (msbuild-sdks entries and <Project Sdk="ANcpLua.NET.Sdk.BitNet"> examples). If this PR merges before the companion PR that strips those instructions, ANcpLua.Agents consumers will follow broken onboarding steps.
Recommend verifying the companion PR lands atomically or first, or adding a deprecation notice to ANcpLua.Agents before removing the SDK variant here.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` around lines 1 - 66, The README links ANcpLua.Agents which
currently documents a BitNet SDK variant (see
src/ANcpLua.Agents.Hosting.BitNet/README.md and usages like <Project
Sdk="ANcpLua.NET.Sdk.BitNet">); ensure the companion PR that removes/changes
that variant lands atomically or update the ANcpLua.Agents docs first: either
coordinate merges so both repos update together or add a clear
deprecation/compatibility notice in ANcpLua.Agents README (and optionally in
this README’s Related section) explaining that the BitNet SDK entry has been
removed and pointing consumers to the correct SDK variants.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@README.md`:
- Around line 1-66: The README links ANcpLua.Agents which currently documents a
BitNet SDK variant (see src/ANcpLua.Agents.Hosting.BitNet/README.md and usages
like <Project Sdk="ANcpLua.NET.Sdk.BitNet">); ensure the companion PR that
removes/changes that variant lands atomically or update the ANcpLua.Agents docs
first: either coordinate merges so both repos update together or add a clear
deprecation/compatibility notice in ANcpLua.Agents README (and optionally in
this README’s Related section) explaining that the BitNet SDK entry has been
removed and pointing consumers to the correct SDK variants.
ℹ️ Review info⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 59e03a62-5359-4bed-8469-7585108318de
📥 Commits
Reviewing files that changed from the base of the PR and between 505902e and 6ea47dd.
📒 Files selected for processing (11)
ANcpLua.NET.Sdk.slnx
README.md
build.ps1
src/ANcpLua.NET.Sdk.BitNet.csproj
src/ANcpLua.NET.Sdk.BitNet.nuspec
src/Build/Common/GlobalPackages.props
src/Build/Common/Version.props
src/Config/ANcpLua.NET.Sdk.BitNet.editorconfig
src/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.props
src/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.targets
tools/SdkGenerator/Program.cs
💤 Files with no reviewable changes (10)
src/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.props
src/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.targets
src/Config/ANcpLua.NET.Sdk.BitNet.editorconfig
ANcpLua.NET.Sdk.slnx
tools/SdkGenerator/Program.cs
src/ANcpLua.NET.Sdk.BitNet.csproj
src/ANcpLua.NET.Sdk.BitNet.nuspec
build.ps1
src/Build/Common/Version.props
src/Build/Common/GlobalPackages.props
📜 Review details⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
*: Use spaces for indentation, not tabs
Trim trailing whitespace from all lines
Use LF (Unix-style) line endings for all files
Files:
README.md
**/*.md
⚙️ CodeRabbit configuration file
Documentation review. Treat docs as executable team memory: flag instructions that disagree with actual scripts, package versions, branch protection, generated-file workflows, or repo layout. Keep AGENTS.md/CLAUDE.md rules coherent with automation. Do not request cosmetic prose changes unless ambiguity would mislead an agent or maintainer.
Multiple runtime/README references to using the ANcpLua.NET.Sdk.BitNet SDK variant and its zero‑ceremony implicit PackageReference: src/ANcpLua.Agents.Hosting.BitNet/README.md (lines referencing msbuild-sdks and ). [::ANcpLua/ANcpLua.Agents::]
The hosting package ANcpLua.Agents.Hosting.BitNet is present and exposes AddQylBitNetChatClient / AddDiscoveredQylBitNetClients; consumers call builder.AddQylBitNetChatClient in Facades/QylBitNetHostingExtensions.cs and generator emits calls to builder.AddQylBitNetChatClient (QylBitNetEndpointGenerator.cs). Files: src/ANcpLua.Agents.Hosting.BitNet/Facades/QylBitNetHostingExtensions.cs, src/ANcpLua.Agents.Hosting.BitNet.Generators/QylBitNetEndpointGenerator.cs. [::ANcpLua/ANcpLua.Agents::]
Tests and test fixtures depend on BitNet hosting and the ANcpLua.Agents.Hosting.BitNet package: tests/ANcpLua.Agents.Tests/Testing/BitNetFixtureSmokeTests.cs, src/ANcpLua.Agents.Testing/BitNet/BitNetFixture.cs, tests/ANcpLua.Agents.Tests/Packaging/PackageBoundaryTests.cs (lists "ANcpLua.Agents.Hosting.BitNet"). [::ANcpLua/ANcpLua.Agents::]
CI/workflow/publishing references packing/publishing of the ANcpLua.Agents.Hosting.BitNet package: .github/workflows/nuget-publish.yml (dotnet pack for ANcpLua.Agents.Hosting.BitNet). [::ANcpLua/ANcpLua.Agents::]
ANcpLua/ANcpLua.Roslyn.Utilities
Test support contains BitNet fixtures/collections used for live-LLM tests: src/ANcpLua.Roslyn.Utilities.Testing/AI/BitNetFixture.cs and BitNetCollection.cs (BitNet test collection/attribute). README mentions live-LLM integration. These test helpers reference a BitNet server and IChatClient. [::ANcpLua/ANcpLua.Roslyn.Utilities::]
Other repositories searched
No matches returned for "BitNet" or the BitNet SDK variant in:
ANcpLua/ANcpLua.Analyzers
O-ANcppLua/ANcpLua.OtelConventions.Api
O-ANcppLua/Nuke.OpenTelemetry.Conventions
ANcpLua/ErrorOrX
ANcpLua/dotcov
ANcpLua/Arqio
ANcpLua/safe-autoresearch
ANcpLua/typespec-otel-semconv
(search stdout empty for these repos). [::ANcpLua/ANcpLua.Analyzers::] [::O-ANcppLua/ANcpLua.OtelConventions.Api::] [::O-ANcppLua/Nuke.OpenTelemetry.Conventions::] [::ANcpLua/ErrorOrX::] [::ANcpLua/dotcov::] [::ANcpLua/Arqio::] [::ANcpLua/safe-autoresearch::] [::ANcpLua/typespec-otel-semconv::]
Implication summary (observed)
The SDK variant removal will require consumer repos (notably ANcpLua.Agents and test infrastructures) to stop relying on the implicit Sdk variant and instead add an explicit PackageReference to ANcpLua.Agents.Hosting.BitNet (the PR already documents this migration). Test fixtures and CI that expect implicit injection or the SDK-provided Version.props value may need updating (e.g., packaging workflows, README examples). All specific references above were observed in the listed files. [::ANcpLua/ANcpLua.Agents::] [::ANcpLua/ANcpLua.Roslyn.Utilities::]
pr-heal: providers tried — CodeRabbit autofix=skipped, Claude=failure. None resolved the block (state was BEHIND). Next sweep in 15 min; if this is recurring, the Codex/Copilot fallback tiers are tracked in pr-heal.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
coderabbitai
Bot
added
area:config
and removed
area:build
area:packaging
area:tools
area:sdk
area:docs
labels
Summary
Remove the
ANcpLua.NET.Sdk.BitNetSDK variant entirely. Consumers wanting BitNet hosting just take a plain<PackageReference Include="ANcpLua.Agents.Hosting.BitNet" />againstANcpLua.NET.Sdk(or.Web).Why
The variant earned one line saved over a plain PackageReference (the implicit injection in
GlobalPackages.props), plus one warning code (ANCPLBITNET001) that only existed because of the SDK. For an alpha-channel feature the NuGet package has 0 dependents on, the carrying cost — separate csproj/nuspec/Sdk.props/Sdk.targets/editorconfig, a Version.props pin to keep in lockstep withANcpLua/ANcpLua.Agentsreleases, generator+packer awareness — was higher than the value.The user will deprecate the existing
ANcpLua.NET.Sdk.BitNetNuGet package separately.What's gone
Deleted (5 files):
src/ANcpLua.NET.Sdk.BitNet.csprojsrc/ANcpLua.NET.Sdk.BitNet.nuspecsrc/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.propssrc/Sdk/ANcpLua.NET.Sdk.BitNet/Sdk.targetssrc/Config/ANcpLua.NET.Sdk.BitNet.editorconfigEdited (6 files):
ANcpLua.NET.Sdk.slnx— remove project entryREADME.md— drop.BitNetentry from theglobal.jsonblock, the<Project Sdk="ANcpLua.NET.Sdk.BitNet">example, and the entire "BitNet variant — what it adds" sectionbuild.ps1— removedotnet pack src/ANcpLua.NET.Sdk.BitNet.csproj …tools/SdkGenerator/Program.cs— remove the.BitNettuple from the generator'ssdks[](so re-running the generator doesn't recreate the deleted Sdk.props/Sdk.targets)src/Build/Common/Version.props— drop the<PropertyGroup Label="BitNet Hosting">withANcpLuaAgentsHostingBitNetVersionsrc/Build/Common/GlobalPackages.props— drop the conditionalItemGroupthat auto-injectedANcpLua.Agents.Hosting.BitNetConsumer migration
Before:
After:
(Version pinned in the consumer's
Directory.Packages.propsunder CPM, which the SDK still enforces.)Companion PR
ANcpLua/ANcpLua.Agents#…— strips the matching "Zero-ceremony path —ANcpLua.NET.Sdk.BitNet" section from the Hosting.BitNet README.Test plan
lint_config,create_nuget(no longer packs the .BitNet nupkg),testmatrix on ubuntu/windows/macos,deployto NuGet onmainmerge.dotnet run --project tools/SdkGeneratorproduces no.BitNetartifacts.ANcpLua.NET.Sdk+<PackageReference Include="ANcpLua.Agents.Hosting.BitNet" />still resolves and callsbuilder.AddQylBitNetChatClient().Generated by Claude Code