chore(fileops): route ShowDirectory OS dispatch through ISystemEnvironment

[ANcpLua]

Summary

• PR chore(ocr): finish ISystemEnvironment abstraction — read via the interface #6 ("finish ISystemEnvironment abstraction — read via the interface") routed Tesseract's file reads through ISystemEnvironment, but FileOperations.ShowDirectory was missed — it still called OperatingSystem.IsWindows() / IsMacOS() directly, leaving the abstraction half-closed on main.
• Route those OS checks through RuntimeSystemEnvironment.Instance so RuntimeSystemEnvironment.cs is now the only production-code site that touches OperatingSystem.*, Environment.Is64BitOperatingSystem, File.Exists, or File.ReadAllTextAsync. That closure property is what "finish the abstraction" actually means.
• Behavior is unchanged. ShowDirectory stays [ExcludeFromCodeCoverage] because Process.Start is the untestable shell-out, not the OS branch.

Verification

• dotnet build — 0 warnings, 0 errors
• dotnet test — 256/256 passing on net10.0, net9.0, net8.0
• Abstraction-closure grep on CreatePdf.NET/:

  grep -rn 'OperatingSystem\.(IsMacOS|IsWindows|IsLinux|IsFreeBSD)|Environment\.Is64BitOperatingSystem|File\.Exists|File\.ReadAllText' CreatePdf.NET/Internal/*.cs
  

  → only RuntimeSystemEnvironment.cs matches as a direct caller; the one TesseractOcrProvider.cs hit (_systemEnvironment.Is64BitOperatingSystem) is interface access, not direct.

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: adf8d853-a679-4c68-b87f-5f1d9b3ce177

📥 Commits

Reviewing files that changed from the base of the PR and between 5d2f6b3 and bdf3294.

📒 Files selected for processing (1)

• CreatePdf.NET/Internal/FileOperations.cs

📜 Recent review details

⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: copilot-pull-request-reviewer
• GitHub Check: build-test

🧰 Additional context used

📓 Path-based instructions (1)

**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.cs: Use field-backed properties with C# 14 features for property definitions where validation is needed
Enable nullable reference types project-wide and use nullable annotations to prevent null reference exceptions
Use async-first approach for all I/O operations in file and PDF generation
Use conditional compilation directives (e.g., #if NET10_0_OR_GREATER) when implementing framework-specific features across .NET 10, 9, and 8 targets
Ensure GenerateDocumentationFile is enabled in .csproj and include comprehensive XML comments in public APIs for documentation generation

Files:

• CreatePdf.NET/Internal/FileOperations.cs

🔇 Additional comments (1)

CreatePdf.NET/Internal/FileOperations.cs (1)

78-85: LGTM!

---

📝 Walkthrough

Summary by CodeRabbit

• Refactor
  • Internal improvements to the directory access mechanism for enhanced maintainability and testability.

Walkthrough

ShowDirectory method now uses a RuntimeSystemEnvironment instance for OS detection instead of direct OperatingSystem static checks, enabling dependency injection and decoupling from the .NET runtime API.

Changes

OS Detection Abstraction

Layer / File(s)	Summary
OS detection abstraction in ShowDirectory CreatePdf.NET/Internal/FileOperations.cs	ShowDirectory obtains RuntimeSystemEnvironment instance and uses its IsWindows/IsMacOS properties for platform-specific command selection, replacing static OperatingSystem.IsWindows()/IsMacOS() checks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: routing OS dispatch through ISystemEnvironment in the ShowDirectory method.
Description check	✅ Passed	The description is directly related to the changeset, explaining the abstraction closure, motivation, and verification performed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/fileops-os-dispatch-via-isystemenvironment

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch chore/fileops-os-dispatch-via-isystemenvironment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR completes the OS-dispatch abstraction for FileOperations.ShowDirectory by routing platform checks through RuntimeSystemEnvironment.Instance instead of calling OperatingSystem.* directly.

Changes:

• Replaces direct OperatingSystem.IsWindows() / IsMacOS() checks with RuntimeSystemEnvironment.Instance properties.
• Keeps existing shell-out behavior unchanged for Windows, macOS, and fallback platforms.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request refactors the ShowDirectory method in FileOperations.cs to utilize a RuntimeSystemEnvironment instance for operating system detection instead of static OperatingSystem checks. The review feedback suggests explicitly typing the environment variable as ISystemEnvironment to ensure the logic depends on the abstraction rather than the concrete implementation, which would also facilitate easier unit testing in the future.

[gemini-code-assist]

To fully adhere to the ISystemEnvironment abstraction and ensure the method depends only on the interface's contract, consider explicitly typing the environment variable as ISystemEnvironment. Using var here infers the concrete RuntimeSystemEnvironment type, which couples the logic to the implementation rather than the abstraction. Additionally, although this method is currently excluded from code coverage, depending on the interface rather than the singleton property would facilitate easier unit testing of the OS-selection logic in the future if the dependency were to be injected.

        ISystemEnvironment environment = RuntimeSystemEnvironment.Instance;