chore(deps): ANcpLua.Roslyn.Utilities 2.2.22 → 2.2.23#155
Conversation
Fleet-consistency bump to the current RU family. 2.2.23 removes the unused async Enumerator member (ANcpLua.Roslyn.Utilities#137); no API surface ErrorOrX uses changes. AL analyzer pin intentionally untouched (dual-ID transition). Build + restore clean.
|
@coderabbitai autofix |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ANcpLua.Roslyn.Utilities dependency from version 2.2.22 to 2.2.23. Codacy analysis indicates the changes are up to standards, with no new issues or complexity increases. The update correctly maintains the AL analyzer pin as per the requirements for the ongoing ErrorOrX ID transition.
Test suggestions
- Verify successful project restore and build with the updated dependency version.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify successful project restore and build with the updated dependency version.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bc7195ae9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PropertyGroup> | ||
| <MeziantouAnalyzerVersion>3.0.93</MeziantouAnalyzerVersion> | ||
| <ANcpLuaRoslynUtilitiesVersion>2.2.22</ANcpLuaRoslynUtilitiesVersion> | ||
| <ANcpLuaRoslynUtilitiesVersion>2.2.23</ANcpLuaRoslynUtilitiesVersion> |
There was a problem hiding this comment.
Pin to a published Roslyn utilities version
In clean restores against this repo's configured package source (nuget.config clears sources and keeps only nuget.org), this version is not resolvable: nuget.org currently lists 2.2.22 as the latest ANcpLua.Roslyn.Utilities/Sources/Testing release, while Directory.Packages.props applies this property to all three package IDs. That means CI or any machine without a private/local cache will fail during restore with a missing package version; keep the pin at 2.2.22 or publish 2.2.23 before merging the bump.
Useful? React with 👍 / 👎.
Triage Bot report
Threads marked |
1 similar comment
Triage Bot report
Threads marked |
|
To use Codex here, create an environment for this repo. |
1 similar comment
|
To use Codex here, create an environment for this repo. |
Summary
Fleet-consistency bump of ANcpLua.Roslyn.Utilities 2.2.22 → 2.2.23 (the family's latest; 2.2.23 removed an unused async helper in ANcpLua.Roslyn.Utilities#137). The AL analyzer pin is deliberately left alone — ErrorOrX is mid dual-ID (AL0xxx/AL1xxx) transition and that pin moves on its own schedule.
Test plan
dotnet restore→ no NU1102dotnet build→ 0 warnings, 0 errors🤖 Generated with Claude Code