Skip to content

Use TreeMaps in SwaggerGenerator to ensure stable openapi.json output#16

Merged
clementdenis merged 1 commit intomasterfrom
sort_swagger_spec_by_name
Mar 21, 2019
Merged

Use TreeMaps in SwaggerGenerator to ensure stable openapi.json output#16
clementdenis merged 1 commit intomasterfrom
sort_swagger_spec_by_name

Conversation

@clementdenis
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     80.06%   80.06%           
  Complexity     1715     1715           
=========================================
  Files           159      159           
  Lines          5718     5718           
  Branches        754      754           
=========================================
  Hits           4578     4578           
  Misses          856      856           
  Partials        284      284
Impacted Files Coverage Δ Complexity Δ
...oogle/api/server/spi/swagger/SwaggerGenerator.java 78.34% <100%> (ø) 60 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b7374...8c01123. Read the comment docs.

Copy link

@llbrt llbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fix the cases I tested (order of API classes, order of fields and methods in Api classes and in DTOs) :-)
I am not sure about the impact of the build (JDK version, order of building of classes), but it will probably work most of the time, if not all the time.
:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

@llbrt llbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@clementdenis clementdenis merged commit 21eb370 into master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants