Skip to content

Replace API explorer with developers.google.com#17

Merged
llbrt merged 1 commit intomasterfrom
non_appspot_api_explorer
Apr 10, 2019
Merged

Replace API explorer with developers.google.com#17
llbrt merged 1 commit intomasterfrom
non_appspot_api_explorer

Conversation

@clementdenis
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage     80.09%   80.09%           
  Complexity     1715     1715           
=========================================
  Files           159      159           
  Lines          5727     5727           
  Branches        753      753           
=========================================
  Hits           4587     4587           
  Misses          856      856           
  Partials        284      284
Impacted Files Coverage Δ Complexity Δ
...oogle/api/server/spi/handlers/ExplorerHandler.java 76.92% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21eb370...3cc4b17. Read the comment docs.

Copy link

@llbrt llbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @clementdenis and @RaHery)


endpoints-framework/src/main/java/com/google/api/server/spi/handlers/ExplorerHandler.java, line 41 at r1 (raw file):

    String url = stripRedundantPorts(Strings.stripTrailingSlash(req.getRequestURL().toString()));
    // This will convert http://localhost:8080/_ah/api/explorer to
    // http://apis-explorer.appspot.com/apis-explorer/?base=http://localhost:8080/_ah/api&

Still a reference on http://apis-explorer.appspot in this comment

@clementdenis clementdenis force-pushed the non_appspot_api_explorer branch from 2fc2610 to 3cc4b17 Compare March 27, 2019 12:22
Copy link

@llbrt llbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @clementdenis)

@llbrt llbrt merged commit de594c5 into master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants