Skip to content

Tools: adds actions to create client code#52

Merged
llbrt merged 3 commits intomasterfrom
tools_gen_client_local
Jan 29, 2020
Merged

Tools: adds actions to create client code#52
llbrt merged 3 commits intomasterfrom
tools_gen_client_local

Conversation

@llbrt
Copy link

@llbrt llbrt commented Jan 28, 2020

  • add actions to create API client source code
    locally when the Google API client code
    generator is installed (command generate_library)

This change is Reviewable

- add actions to create API client source code
  locally when the Google API client code
  generator is installed (command generate_library)
@llbrt llbrt requested a review from clementdenis January 28, 2020 11:32
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #52 into master will decrease coverage by 0.03%.
The diff coverage is 79.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
- Coverage     82.51%   82.47%   -0.04%     
- Complexity     1827     1836       +9     
============================================
  Files           156      159       +3     
  Lines          6621     6689      +68     
  Branches        878      881       +3     
============================================
+ Hits           5463     5517      +54     
- Misses          846      859      +13     
- Partials        312      313       +1
Impacted Files Coverage Δ Complexity Δ
...com/google/api/server/spi/tools/EndpointsTool.java 88.37% <100%> (+0.56%) 8 <0> (ø) ⬇️
...oogle/api/server/spi/tools/GenClientSrcAction.java 60% <60%> (ø) 2 <2> (?)
...oogle/api/server/spi/tools/GetClientSrcAction.java 78.57% <78.57%> (ø) 3 <3> (?)
.../api/server/spi/tools/LocalClientLibGenerator.java 91.3% <91.3%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45588b5...31e10f2. Read the comment docs.

@llbrt llbrt force-pushed the tools_gen_client_local branch 2 times, most recently from c9c56ba to 8802d5d Compare January 28, 2020 13:50
- add python and the code generator for
  the unit test of the API client code
  generation
@llbrt llbrt force-pushed the tools_gen_client_local branch from 8802d5d to 08fd41d Compare January 28, 2020 13:55
Copy link

@clementdenis clementdenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@llbrt llbrt merged commit a720457 into master Jan 29, 2020
@llbrt llbrt deleted the tools_gen_client_local branch January 29, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants