Skip to content

fix(script): ignore hostname (and other) to fix scp -r completion req #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

fix(script): ignore hostname (and other) to fix scp -r completion req #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions scripts/bash_pinyin_completion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,29 @@ _comp_compgen__call_builtin() {
local compgen_args=("$@")

# Check for file completion indicators
for arg in "${compgen_args[@]}"; do
local idx=0
while [[ $idx -lt ${#compgen_args[@]} ]]; do
local arg="${compgen_args[$idx]}"
case "$arg" in
-f|-d|-A|file|directory)
-f|-d|-Afile|-Adirectory)
is_file_completion=true
break
;;
-A)
if (( idx + 1 < ${#compgen_args[@]} )); then
local next_arg="${compgen_args[$((idx + 1))]}"
if [[ "$next_arg" == "file" || "$next_arg" == "directory" ]]; then
is_file_completion=true
break
fi
fi
;;
file|directory)
is_file_completion=true
break
;;
esac
((idx++))
done

# Also check if -W option is used with ${files[@]} or similar array expansion
Expand Down