Merged
Conversation
Feature/private refactor
Add cvi.MODULES
Feature/gd43
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 99.08% 99.18% +0.09%
==========================================
Files 7 9 +2
Lines 439 616 +177
==========================================
+ Hits 435 611 +176
- Misses 4 5 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NiklasMelton
requested changes
Sep 21, 2022
Collaborator
NiklasMelton
left a comment
NiklasMelton
left a comment
There was a problem hiding this comment.
Looks good but make all the internal variables private
| super()._setup_batch(data) | ||
|
|
||
| # Take the average across all samples, but cast to 1-D vector | ||
| self.mu = np.mean(data, axis=0) |
Collaborator
There was a problem hiding this comment.
should all be private
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR folds in release v0.2.0. This new subversion changes the internals with privatization and adds more CVIs.