Skip to content

Mobile lab short delta only#85

Merged
rayeswong merged 18 commits intomasterfrom
MobileLab-short-delta-only
Aug 21, 2017
Merged

Mobile lab short delta only#85
rayeswong merged 18 commits intomasterfrom
MobileLab-short-delta-only

Conversation

@rayeswong
Copy link
Copy Markdown
Contributor

Created a short version of the mobile lab. Please help to test and review before merging to master. You can find the MBE package for testing under "CloudNative_Mobile\common\assets\mobile\MBE Packages". Thanks!

Copy link
Copy Markdown
Contributor

@heungheung heungheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except... 401.
10 - can be us2, em2 or em3
12 - can be us2, em2 or em3
change is not a must but if you have time, better make it less confused

@heungheung
Copy link
Copy Markdown
Contributor

I don't have time to test. BTW, where are the packages files to be uploaded?

@cholho
Copy link
Copy Markdown
Contributor

cholho commented Aug 21, 2017

@rayeswong

Please refer to my comments as below:
(1) Android APK file
Need to replace the link for Android APK file in the prerequisites and replace the APK file in the ../common/mobile/assets/ folder.

(2) Package file
I assumed we are going to give participants MBE package file using thumb drive. Is it correct?

(3) Lab 401

  • Please search "successully" and replace it with "successfully"
  • Please search "clieck" and replace it with "click"
  • Please search "authorzied" and replace it with "authorized"

Others look good even though I can't go through all of lab without a package file.
Regards,
CholHo.

@rayeswong
Copy link
Copy Markdown
Contributor Author

@cholho Thanks for the comments.

(1) Android APK file
This is strange. The mobile "Mobile lab short delta only" branch points to "master", but it looks the master branch has not updated. I did minor change to see if that can be changed.

(2) Package file
I've placed the example MBE package on "..\common\assets\mobile\MBE Packages" where you can get the package file and test.
I will generate all the 20 packages today and place those onto the same folder.
I assume we will give participants the MBE package file by using the thumb drive, same as the iar file in "integrations" lab.

(3) Lab 401
All are updated in the "Mobile lab short delta only" branch. I will create another pull request later today.

@heungheung
Copy link
Copy Markdown
Contributor

There won't be 20 thumb drive. Be prepared participant need to download the files during the labs.

@heungheung
Copy link
Copy Markdown
Contributor

Also. If you update the APK link within your branch and you also update the APK file itself. The change will be indicated in your branch and will be effective after the merge in master.

@heungheung
Copy link
Copy Markdown
Contributor

I mean before the merge, the APK itself will NOT be available in master, but only in the branch.

That's why we are supposed to use relative links.

@cholho
Copy link
Copy Markdown
Contributor

cholho commented Aug 21, 2017

@rayeswong @heungheung @choichi

FYI,
I will update the main image of introduction "README.md" in this branch.

@heungheung
Copy link
Copy Markdown
Contributor

@rayeswong the reason of the APK link problem. You've upload the APK to common/assets/mobile/Cafe_Supremo.apk but your link is point to ../common/assets/mobile/Cafe_Supremo.apk

@rayeswong
Copy link
Copy Markdown
Contributor Author

@cholho @heungheung @choichi @kwanwan
Done creating the MBE packages and uploaded onto
https://github.com/APACTestDrive/CloudNative_Mobile/tree/MobileLab-short-delta-only/common/assets/mobile/import/MBE%20Packages

Whoever has time today, please help on testing.

Also we can have the India SCs to help testing.

@heungheung
Copy link
Copy Markdown
Contributor

heungheung commented Aug 21, 2017

@rayeswong wow.... this really change a lot.... so, they don't have to create MBC / Connector, only edit API..... the lab should be finished within an hour.... 😄

@rayeswong rayeswong merged commit 6eca4f5 into master Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants