Skip to content

add Git client install#90

Merged
heungheung merged 1 commit intomasterfrom
JavaAppsLab-delta-only
Aug 22, 2017
Merged

add Git client install#90
heungheung merged 1 commit intomasterfrom
JavaAppsLab-delta-only

Conversation

@heungheung
Copy link
Copy Markdown
Contributor

For windows, git client is required

Copy link
Copy Markdown
Contributor

@choichi choichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment: Would move the gitclient installation before bracket installation (line 54 - 56 @ README) better?

@heungheung
Copy link
Copy Markdown
Contributor Author

I am neutral.... original what to do what you said but think some might actually already got GIT.... so... struggled for a while..... anyone want to vote?

@choichi
Copy link
Copy Markdown
Contributor

choichi commented Aug 22, 2017

Yes very minor and that's why I approved for merge.
Not sure about Git popularity in India..... I vote for Git client installation 1st...

@rayeswong
Copy link
Copy Markdown
Contributor

Just a quick thought, can we have this in another page, and only those people who don't have git installed should refer to a link that points to the guideline of git installation?

@heungheung
Copy link
Copy Markdown
Contributor Author

@rayeswong please put it as issue..... Too much to be done in this instance and I will only treat what you suggested as enhancement 😄

@heungheung heungheung merged commit b379055 into master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants