Skip to content

Criterion context validation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcatanese merged 1 commit into from
Feb 3, 2024
Merged

Criterion context validation #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/apiflows/parser/OpenAPIWorkflowValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,10 @@ List<String> validateCriterion(Criterion criterion, String stepId) {
errors.add("Step " + stepId + " SuccessCriteria type (" + criterion.getType() + ") is invalid");
}

if (criterion.getType() != null && criterion.getContext() == null) {
errors.add("Step " + stepId + " SuccessCriteria type is specified but context is not provided");
}

return errors;
}

Expand Down
18 changes: 16 additions & 2 deletions src/test/java/com/apiflows/parser/OpenAPIWorkflowValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,8 @@ void validateCriterion() {

Criterion criterion = new Criterion()
.condition("$statusCode == 200")
.type("simple");
.type("simple")
.context("$response.body");

assertEquals(0, validator.validateCriterion(criterion, stepId).size());
}
Expand All @@ -301,7 +302,20 @@ void validateCriterionInvalidType() {

Criterion criterion = new Criterion()
.condition("$statusCode == 200")
.type("dummy");
.type("dummy")
.context("$response.body");

assertEquals(1, validator.validateCriterion(criterion, stepId).size());
}

@Test
void validateCriterionMissingContext() {
String stepId = "step-one";

Criterion criterion = new Criterion()
.condition("$statusCode == 200")
.type("simple")
.context(null);

assertEquals(1, validator.validateCriterion(criterion, stepId).size());
}
Expand Down