Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,11 @@ List<String> validateParameter(Parameter parameter, String workflowId ) {
errors.add("'Workflow[" + workflowId + "]' parameter has no value");
}
}
if(parameter.getTarget() != null) {
if(!isValidJsonPointer(parameter.getTarget())) {
errors.add("Parameter '" + name + "' target is not a valid Json Pointer");
}
}
}
return errors;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ void parseFromFile() {

OpenAPIWorkflowParserResult result = parser.parse(WORKFLOWS_SPEC_FILE);
assertNotNull(result.getOpenAPIWorkflow());
assertEquals("1.0.0", result.getOpenAPIWorkflow().getWorkflowsSpec());
assertEquals("1.0.0-prerelease", result.getOpenAPIWorkflow().getWorkflowsSpec());
assertNotNull(result.getOpenAPIWorkflow().getInfo());
assertEquals("Petstore - Apply Coupons", result.getOpenAPIWorkflow().getInfo().getTitle());
assertNotNull(result.getOpenAPIWorkflow().getComponents());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -708,9 +708,9 @@ void invalidJsonPointer() {
assertFalse(new OpenAPIWorkflowValidator().isValidJsonPointer("user/id"));
}

// @Test
// void isValidJsonPointer2() {
// assertTrue(new OpenAPIWorkflowValidator().isValidJsonPointer("#/petId"));
// }
@Test
void invalidJsonPointerSyntax() {
assertFalse(new OpenAPIWorkflowValidator().isValidJsonPointer("#/petId"));
}

}
12 changes: 6 additions & 6 deletions src/test/resources/1.0.0/pet-coupons.workflow.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
workflowsSpec: 1.0.0
workflowsSpec: 1.0.0-prerelease
info:
title: Petstore - Apply Coupons
version: 1.0.0
Expand Down Expand Up @@ -116,22 +116,22 @@ workflows:
parameters:
- name: pet_id
in: body
target: $request.body#/petId
target: /petId
value: $inputs.pet_id
- name: coupon_code
in: body
target: $request.body#/couponCode
target: /couponCode
value: $inputs.coupon_code
- name: quantity
in: body
value: $inputs.quantity
- name: status
in: body
target: $request.body#/status
target: /status
value: "placed"
- name: complete
in: body
target: $request.body#/complete
target: /complete
value: false
successCriteria:
- condition: $statusCode == 200
Expand Down Expand Up @@ -165,4 +165,4 @@ components:
format: int32
pageSize:
type: integer
format: int32
format: int32