Skip to content

Conversation

@nickzelei
Copy link

@nickzelei nickzelei commented Jun 19, 2019

Moved the openapi-types package to be a direct dependency. This will allow the types to be resolved in the included index.d.ts file.

Addresses #117

"version": "1.3.5",
"resolved": "https://registry.npmjs.org/openapi-types/-/openapi-types-1.3.5.tgz",
"integrity": "sha512-11oi4zYorsgvg5yBarZplAqbpev5HkuVNPlZaPTknPDzAynq+lnJdXAmruGWP0s+dNYZS7bjM+xrTpJw7184Fg==",
"dev": true
Copy link
Author

@nickzelei nickzelei Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the "dev" property did not get removed when I moved the dependencies. I tried a few different things and the openapi-types module stayed put even when I ran npm remove openapi-types.

I manually edited this file to remove this flag. I primarily use yarn, so am no longer in touch with the nuances of npm.

@coveralls
Copy link

coveralls commented Jun 19, 2019

Pull Request Test Coverage Report for Build 334

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.809%

Totals Coverage Status
Change from base Build 333: 0.0%
Covered Lines: 223
Relevant Lines: 229

💛 - Coveralls

@ffflorian
Copy link

Hi @Zelein, great to see your PR, I also need this for DefinitelyTyped/DefinitelyTyped#36165. So hopefully this gets merged soon 🙂

@JamesMessinger JamesMessinger merged commit 2605362 into APIDevTools:master Jun 21, 2019
@JamesMessinger
Copy link
Member

Thanks! Good catch

@ffflorian
Copy link

🎉

@nickzelei nickzelei deleted the b1 branch June 21, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants