Skip to content

cleanup tests#71

Merged
nbassler merged 10 commits into
mainfrom
64-modernize-repository
Mar 28, 2026
Merged

cleanup tests#71
nbassler merged 10 commits into
mainfrom
64-modernize-repository

Conversation

@nbassler
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 28, 2026 20:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes and simplifies the test suite by removing legacy “all-in-one” test programs, adding small focused test executables, and extending CI with an install/consumer smoke test plus a dedicated Valgrind job.

Changes:

  • Remove legacy test drivers (tests/test.c, tests/loadTest.c) and rely on one-test-per-file executables.
  • Add new smoke tests for workspace initialization and config loading, plus an install+consumer check via a CMake script.
  • Update CI to fail on CTest failures and run Valgrind in a separate job; refresh VS Code project settings accordingly.

Reviewed changes

Copilot reviewed 17 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_pstar.c Update reference comment to point to NIST PSTAR source.
tests/test_load_configs.c New config-loading smoke test across several program/ion/target combinations.
tests/test_initialize.c New workspace allocate/free smoke test.
tests/test_icru73_old.c Add reference provenance comment for ICRU73 old parametrization.
tests/test_icru73.c Add reference provenance comment for ICRU73.
tests/test_icru49.c Add reference provenance comment for ICRU49.
tests/test_icru.c Add comment describing ICRU alias behavior.
tests/test_astar.c Add NIST ASTAR reference comment.
tests/test.c Remove large legacy test runner.
tests/loadTest.c Remove legacy “loadTest” driver used by old CTest entries.
tests/install_smoke_test.cmake Add CMake-driven install/build + consumer compile/run smoke test.
tests/install_consumer.c Add a tiny “installed headers + link + runtime” consumer program.
tests/CMakeLists.txt Switch to globbed test_*.c executables + add test_install_consumer.
.vscode/settings.json Switch to CMake Presets and adjust language-server notes.
.vscode/launch.json Remove legacy loadTest debug config; adjust working directory.
.vscode/extensions.json Small formatting/cleanup of extension recommendations.
.github/workflows/ci.yml Make CTest failures fatal; move Valgrind into a separate job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_load_configs.c
Comment thread tests/test_load_configs.c
Comment thread tests/install_smoke_test.cmake
@nbassler nbassler linked an issue Mar 28, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@nbassler nbassler merged commit ad6139d into main Mar 28, 2026
13 of 15 checks passed
@nbassler nbassler linked an issue Mar 28, 2026 that may be closed by this pull request
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modernize repository implement CTEST framework

2 participants