cleanup tests#71
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes and simplifies the test suite by removing legacy “all-in-one” test programs, adding small focused test executables, and extending CI with an install/consumer smoke test plus a dedicated Valgrind job.
Changes:
- Remove legacy test drivers (
tests/test.c,tests/loadTest.c) and rely on one-test-per-file executables. - Add new smoke tests for workspace initialization and config loading, plus an install+consumer check via a CMake script.
- Update CI to fail on CTest failures and run Valgrind in a separate job; refresh VS Code project settings accordingly.
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_pstar.c | Update reference comment to point to NIST PSTAR source. |
| tests/test_load_configs.c | New config-loading smoke test across several program/ion/target combinations. |
| tests/test_initialize.c | New workspace allocate/free smoke test. |
| tests/test_icru73_old.c | Add reference provenance comment for ICRU73 old parametrization. |
| tests/test_icru73.c | Add reference provenance comment for ICRU73. |
| tests/test_icru49.c | Add reference provenance comment for ICRU49. |
| tests/test_icru.c | Add comment describing ICRU alias behavior. |
| tests/test_astar.c | Add NIST ASTAR reference comment. |
| tests/test.c | Remove large legacy test runner. |
| tests/loadTest.c | Remove legacy “loadTest” driver used by old CTest entries. |
| tests/install_smoke_test.cmake | Add CMake-driven install/build + consumer compile/run smoke test. |
| tests/install_consumer.c | Add a tiny “installed headers + link + runtime” consumer program. |
| tests/CMakeLists.txt | Switch to globbed test_*.c executables + add test_install_consumer. |
| .vscode/settings.json | Switch to CMake Presets and adjust language-server notes. |
| .vscode/launch.json | Remove legacy loadTest debug config; adjust working directory. |
| .vscode/extensions.json | Small formatting/cleanup of extension recommendations. |
| .github/workflows/ci.yml | Make CTest failures fatal; move Valgrind into a separate job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Closed
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.