Conversation
- Changed the return type of dedx_load_config from void to int, allowing it to return success or failure status. - Deleted the dedx_atima.c and dedx_atima.h files, removing unused ATIMA-related functions and data. - Updated error codes in dedx_error.h to remove references to ATIMA. - Removed the _dedx_get_atima_data function from dedx_file_access.c and its declaration in dedx_file_access.h. - Added tests in test_error_codes.c to verify error handling for invalid dataset IDs and configuration loading failures.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 70.54% 73.98% +3.43%
==========================================
Files 34 37 +3
Lines 2397 2856 +459
Branches 291 387 +96
==========================================
+ Hits 1691 2113 +422
+ Misses 698 693 -5
- Partials 8 50 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses error-handling correctness around configuration loading and stopping-power evaluation, and removes unused ATIMA-related code/data from libdedx.
Changes:
- Make
dedx_load_config()return success/failure and ensure failed loads don’t mark configs as loaded or assign a dataset id. - Fix
dedx_get_stp()to reject invalid dataset ids before dereferencing workspace data (preventing crashes). - Remove ATIMA-related headers/sources/data and the reserved ATIMA error code.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_error_codes.c | Adds regression tests for failed-load state and invalid dataset id handling. |
| libdedx/dedx.h | Changes dedx_load_config to return int and documents return value. |
| libdedx/dedx.c | Implements new dedx_load_config contract; fixes dataset-id validation order; refactors/cleans internal helpers and workspace allocation. |
| libdedx/dedx_tools.c | Removes stale TODO comments in CSDA/tooling helpers. |
| libdedx/dedx_file_access.h | Removes unused ATIMA file-access API declaration. |
| libdedx/dedx_file_access.c | Avoids probing empty local data path; removes ATIMA data reader implementation. |
| libdedx/dedx_error.h | Removes reserved ATIMA error code and updates doxygen range. |
| libdedx/dedx_atima.h | Deletes ATIMA header (unused). |
| libdedx/dedx_atima.c | Deletes ATIMA implementation (unused/incomplete). |
| libdedx/data/atima_compos | Removes ATIMA composition data file from the repo. |
| libdedx/CMakeLists.txt | Removes ATIMA data file from install/binary data lists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ry management in dedx_wrappers.c
…ude dedx_elements.h
… typedefs to appropriate headers
…rparts for improved consistency and clarity
…clarity and organization
…e program identifiers for improved clarity and consistency
…or improved consistency and clarity
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 50 out of 50 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nbassler
deleted the
74-resolve-outstanding-todofixme-comments-in-source
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.