Skip to content

Conversation

@edoardolegnaro
Copy link
Contributor

YOLO code for FD detection and classification

@edoardolegnaro edoardolegnaro requested a review from samaloney May 27, 2025 14:30
Copy link
Contributor

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, few small questions but nothing to hold this up too long.

data = np.nan_to_num(data, nan=0.0)
data = ut_v.hardtanh_transform_npy(data)
crota2 = header["CROTA2"]
data = rotate(data, crota2, reshape=False, mode="constant", cval=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data should all be rotated to solar north already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some were not, with some I was having isssues with boxes location and this was needed

Copy link
Contributor

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened issue for the open comments and reran the doc build which is now green - so good to go!

@edoardolegnaro edoardolegnaro deleted the YOLO branch June 6, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants