Skip to content

Pr/timeseries#203

Merged
samaloney merged 8 commits intoARCAFF:mainfrom
edoardolegnaro:pr/timeseries
Mar 4, 2026
Merged

Pr/timeseries#203
samaloney merged 8 commits intoARCAFF:mainfrom
edoardolegnaro:pr/timeseries

Conversation

@edoardolegnaro
Copy link
Copy Markdown
Contributor

@edoardolegnaro edoardolegnaro commented Mar 3, 2026

Updated models, visualisation and EDA notebooks.

  • Migrates and consolidates arccnet/models
  • Updates visualisation helpers and data access logic.
  • Updates EDAnotebooks for cutouts, flares, fulldisk, and timeseries workflows.
  • Adds/updates tests for new model utilities and timeseries functionality.
  • Adds fpr/FPR to codespell ignore list to avoid pre-commit issues on standard metric naming.

from pathlib import Path

# Ensure parent package is importable
sys.path.insert(0, str(Path(__file__).parent.parent.parent.parent))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these shouldn't be needed ?

from pathlib import Path

# Add parent directory to path
sys.path.insert(0, str(Path(__file__).parent.parent.parent.parent))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest arccnet/models/timeseries

@samaloney
Copy link
Copy Markdown
Contributor

samaloney commented Mar 3, 2026

You'll need to merge main into this to fix the CI - I tried to push the change but for permission denied.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 35.11808% with 3599 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@86adee1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
arccnet/models/flares/multiclass/train.py 14.98% 244 Missing ⚠️
arccnet/models/flares/multiclass/model.py 15.35% 204 Missing ⚠️
arccnet/models/timeseries/lightning_module.py 12.17% 202 Missing ⚠️
arccnet/models/timeseries/train.py 32.43% 200 Missing ⚠️
arccnet/models/fulldisk/utils.py 16.38% 199 Missing ⚠️
arccnet/models/cutouts/hale/evaluation.py 11.22% 174 Missing ⚠️
arccnet/models/cutouts/hale/cross_validation.py 15.50% 169 Missing ⚠️
arccnet/models/cutouts/hale/logging_utils.py 10.75% 166 Missing ⚠️
arccnet/models/cutouts/hale/trainer.py 20.33% 141 Missing ⚠️
arccnet/models/timeseries/evaluate.py 27.56% 134 Missing ⚠️
... and 43 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage        ?   37.03%           
=======================================
  Files           ?       90           
  Lines           ?    10141           
  Branches        ?        0           
=======================================
  Hits            ?     3756           
  Misses          ?     6385           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samaloney samaloney merged commit 1f68ecd into ARCAFF:main Mar 4, 2026
11 checks passed
@edoardolegnaro edoardolegnaro deleted the pr/timeseries branch March 18, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants