Skip to content

Prohibit identical currencies #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kirillt merged 3 commits into from
Jan 30, 2025
Merged

Prohibit identical currencies #137

kirillt merged 3 commits into from
Jan 30, 2025

Conversation

@mdrlzy
Copy link
Member

@mdrlzy mdrlzy commented Dec 27, 2024 •
edited by kirillt
Loading

Portfolio screen ⏤ prevent selecting same currency twice:

Quick screen ⏤ source and base currencies should always be different for a valid calculation:

@mdrlzy mdrlzy requested review from hieuwu and shubertm December 27, 2024 12:34
@kirillt kirillt self-requested a review January 30, 2025 12:10
kirillt
kirillt approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@kirillt kirillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • brief QA check
  • code review

@kirillt kirillt merged commit d60d770 into main Jan 30, 2025
5 checks passed
@kirillt kirillt deleted the feat/prohibit-identical-currencies branch May 20, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirillt kirillt kirillt approved these changes

@hieuwu hieuwu Awaiting requested review from hieuwu

@shubertm shubertm Awaiting requested review from shubertm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdrlzy @kirillt