FIX: Update URL configuration for ARM JupyterHub compatibility#1013
Merged
Conversation
Collaborator
|
Thanks for the PR @michaeltg12 ! Only suggestion is on line 304 of that file we use the same url as well, are you able to update that line as well? |
zssherman
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the URLs used for the ARM Live data download (act.discovery.download_arm_data) and the DQR webservice (act.qc.add_dqr_to_qc).
Previously, the URL structure encountered connection and routing errors when executed from within the ARM JupyterHub cluster due to its specific proxy and ingress controller setup. The endpoints have been updated to use the new proxy path, which resolves successfully both from within the ARM Kubernetes cluster and from outside of it.
[x] Closes #1011
[x] PEP8 Standards or use of linter