Skip to content

Update core_ca.h#216

Merged
JonatanAntoni merged 1 commit intoARM-software:mainfrom
NVMarkovich:patch-1
Apr 28, 2025
Merged

Update core_ca.h#216
JonatanAntoni merged 1 commit intoARM-software:mainfrom
NVMarkovich:patch-1

Conversation

@NVMarkovich
Copy link
Copy Markdown
Contributor

Small bugs fixed

@JonatanAntoni
Copy link
Copy Markdown
Member

@Masmiseim36, could you double check this one?

Comment thread CMSIS/Core/Include/core_ca.h
Comment thread CMSIS/Core/Include/core_ca.h
Comment thread CMSIS/Core/Include/core_ca.h
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2025

Test Results

   264 files   -   108     264 suites   - 108   0s ⏱️ - 8m 37s
    56 tests +    7      54 ✅ + 10      2 💤  -     3  0 ❌ ±0 
14 292 runs   - 3 936  12 124 ✅ +160  2 168 💤  - 4 096  0 ❌ ±0 

Results for commit 7cee9f9. ± Comparison against base commit 6675bec.

This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both.
CMSIS-Core.src ‑ apsr.c
CMSIS-Core.src ‑ basepri.c
CMSIS-Core.src ‑ bkpt.c
CMSIS-Core.src ‑ clrex.c
CMSIS-Core.src ‑ clz.c
CMSIS-Core.src ‑ control.c
CMSIS-Core.src ‑ cp15.c
CMSIS-Core.src ‑ cpsr.c
CMSIS-Core.src ‑ dmb.c
CMSIS-Core.src ‑ dsb.c
…
TC_CML1Cache_CleanDCacheByAddrWhileDisabled
TC_CML1Cache_EnDisableDCache
TC_CML1Cache_EnDisableICache
TC_CoreFunc_APSR
TC_CoreFunc_BASEPRI
TC_CoreFunc_Control
TC_CoreFunc_EnDisIRQ
TC_CoreFunc_EncDecIRQPrio
TC_CoreFunc_FAULTMASK
TC_CoreFunc_FPSCR
…
This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
CMSIS-Core.src ‑ lda.c
CMSIS-Core.src ‑ ldaex.c
CMSIS-Core.src ‑ stl.c
CMSIS-Core.src ‑ stlex.c
CMSIS-Core.src ‑ systick.c
TC_CoreInstr_WFE
TC_CoreInstr_WFI

♻️ This comment has been updated with latest results.

@JonatanAntoni
Copy link
Copy Markdown
Member

@Masmiseim36, do you request any change or can we resolve discussions and merge?

@Masmiseim36
Copy link
Copy Markdown
Contributor

@Masmiseim36, do you request any change or can we resolve discussions and merge?

The changes are okay, but I would also adapt the documentation at https://github.com/ARM-software/CMSIS_6/blob/main/CMSIS/Documentation/Doxygen/Core_A/src/ref_gic.txt accordingly. I can't advise whether you want this in this pull request or in a separate one.

@JonatanAntoni
Copy link
Copy Markdown
Member

Ideally, we keep code and documentation changes in the same PR. But we can split it if required.

@JonatanAntoni
Copy link
Copy Markdown
Member

@Masmiseim36, @NVMarkovich, would you want to update some documentation alongside this change, or shall we merge the code changes?

@Masmiseim36
Copy link
Copy Markdown
Contributor

@Masmiseim36, @NVMarkovich, would you want to update some documentation alongside this change, or shall we merge the code changes?

I have created a Pull-Request for the documentation change: #233

Small bugs fixed
@JonatanAntoni JonatanAntoni merged commit 218b036 into ARM-software:main Apr 28, 2025
8 checks passed
tpambor pushed a commit to tpambor/CMSIS_6 that referenced this pull request Jun 20, 2025
wearyzen pushed a commit to zephyrproject-rtos/CMSIS_6 that referenced this pull request Jun 23, 2025
wearyzen added a commit to zephyrproject-rtos/CMSIS_6 that referenced this pull request Jun 23, 2025
wearyzen added a commit to zephyrproject-rtos/CMSIS_6 that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants