Skip to content

Bug fix in GIC_GetConfiguration()#217

Merged
JonatanAntoni merged 1 commit intoARM-software:mainfrom
NVMarkovich:patch-2
Feb 24, 2025
Merged

Bug fix in GIC_GetConfiguration()#217
JonatanAntoni merged 1 commit intoARM-software:mainfrom
NVMarkovich:patch-2

Conversation

@NVMarkovich
Copy link
Copy Markdown
Contributor

Bit shift in accordance with IRQn % 16 was incorrect, and masking was needed to extract only the IRQn bits. Both fixed.

@jkrech jkrech requested a review from JonatanAntoni February 4, 2025 14:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2025

Test Results

   264 files   -   108     264 suites   - 108   0s ⏱️ - 8m 53s
    56 tests +    7      54 ✅ + 10      2 💤  -     3  0 ❌ ±0 
14 292 runs   - 3 936  12 124 ✅ +160  2 168 💤  - 4 096  0 ❌ ±0 

Results for commit f4e66ec. ± Comparison against base commit 1a1799c.

This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both.
CMSIS-Core.src ‑ apsr.c
CMSIS-Core.src ‑ basepri.c
CMSIS-Core.src ‑ bkpt.c
CMSIS-Core.src ‑ clrex.c
CMSIS-Core.src ‑ clz.c
CMSIS-Core.src ‑ control.c
CMSIS-Core.src ‑ cp15.c
CMSIS-Core.src ‑ cpsr.c
CMSIS-Core.src ‑ dmb.c
CMSIS-Core.src ‑ dsb.c
…
TC_CML1Cache_CleanDCacheByAddrWhileDisabled
TC_CML1Cache_EnDisableDCache
TC_CML1Cache_EnDisableICache
TC_CoreFunc_APSR
TC_CoreFunc_BASEPRI
TC_CoreFunc_Control
TC_CoreFunc_EnDisIRQ
TC_CoreFunc_EncDecIRQPrio
TC_CoreFunc_FAULTMASK
TC_CoreFunc_FPSCR
…
This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
CMSIS-Core.src ‑ lda.c
CMSIS-Core.src ‑ ldaex.c
CMSIS-Core.src ‑ stl.c
CMSIS-Core.src ‑ stlex.c
CMSIS-Core.src ‑ systick.c
TC_CoreInstr_WFE
TC_CoreInstr_WFI

@JonatanAntoni JonatanAntoni merged commit 8d9972d into ARM-software:main Feb 24, 2025
@NVMarkovich NVMarkovich deleted the patch-2 branch February 24, 2025 09:17
@NVMarkovich
Copy link
Copy Markdown
Contributor Author

Thank You, Jonatan!

tpambor pushed a commit to tpambor/CMSIS_6 that referenced this pull request Jun 20, 2025
Bit shift in accordance with IRQn % 16 was incorrect, and masking was
needed to extract only the IRQn bits. Both fixed.
wearyzen pushed a commit to zephyrproject-rtos/CMSIS_6 that referenced this pull request Jun 23, 2025
Bit shift in accordance with IRQn % 16 was incorrect, and masking was
needed to extract only the IRQn bits. Both fixed.
wearyzen added a commit to zephyrproject-rtos/CMSIS_6 that referenced this pull request Jun 23, 2025
wearyzen added a commit to zephyrproject-rtos/CMSIS_6 that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants