Add missing CPPWR definitions#243
Merged
JonatanAntoni merged 1 commit intoARM-software:mainfrom Jun 23, 2025
Merged
Conversation
Added missing Coprocessor Power Control Register Definitions to the v8m-mainline cpus. Signed-off-by: Dávid Házi <david.hazi@arm.com>
Test Results 264 files - 108 264 suites - 108 0s ⏱️ - 8m 28s Results for commit dbf0888. ± Comparison against base commit 6f0a58d. This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing Coprocessor Power Control Register (CPPWR) bit definitions for SUS10/SU10 and SUS11/SU11 across several v8m‐mainline CPU headers and updates copyright years.
- Bumped Arm Limited copyright years from 2024 to 2025.
- Introduced
*_CPPWR_SUS11_Pos,*_CPPWR_SU11_Pos,*_CPPWR_SUS10_Pos, and corresponding masks in four core headers.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMSIS/Core/Include/core_starmc1.h | Updated copyright year; added SCnSCB CPPWR SUS/SU bit definitions. |
| CMSIS/Core/Include/core_cm52.h | Updated copyright year; added ICB CPPWR SUS/SU bit definitions. |
| CMSIS/Core/Include/core_cm35p.h | Updated copyright year; added SCnSCB CPPWR SUS/SU bit definitions. |
| CMSIS/Core/Include/core_cm33.h | Updated copyright year; added SCnSCB CPPWR SUS/SU bit definitions. |
Comments suppressed due to low confidence (2)
CMSIS/Core/Include/core_cm52.h:2
- For consistency, consider bumping the second copyright year for Arm Technology (China) Co., Ltd. from 2024 to 2025.
* Copyright (c) 2018-2025 Arm Limited. Copyright (c) 2024 Arm Technology (China) Co., Ltd. All rights reserved.
CMSIS/Core/Include/core_cm52.h:1079
- There are no tests or static assertions validating these new bit positions and masks; adding coverage will help catch mismatches against the hardware specification.
#define ICB_CPPWR_SUS11_Pos 23U /*!< CPPWR: SUS11 Position */
JonatanAntoni
approved these changes
Jun 23, 2025
valeriosetti
pushed a commit
to valeriosetti/CMSIS_6
that referenced
this pull request
Apr 27, 2026
Added missing Coprocessor Power Control Register Definitions to the v8m-mainline cpus. Signed-off-by: Dávid Házi <david.hazi@arm.com>
valeriosetti
pushed a commit
to valeriosetti/CMSIS_6
that referenced
this pull request
Apr 27, 2026
Added missing Coprocessor Power Control Register Definitions to the v8m-mainline cpus. Signed-off-by: Dávid Házi <david.hazi@arm.com>
valeriosetti
pushed a commit
to valeriosetti/CMSIS_6
that referenced
this pull request
Apr 29, 2026
Added missing Coprocessor Power Control Register Definitions to the v8m-mainline cpus. Signed-off-by: Dávid Házi <david.hazi@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing Coprocessor Power Control Register Definitions to the v8m-mainline cpus.