-
Notifications
You must be signed in to change notification settings - Fork 67
Add intrinsic support for the range prefetch (RPRFM) instruction #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kmclaughlin-arm
wants to merge
6
commits into
ARM-software:main
Choose a base branch
from
kmclaughlin-arm:range-prefetch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8ab80d6
Add intrinsic support for the range prefetch (RPRFM) instruction.
kmclaughlin-arm d9b772a
- Define Count as the number of data blocks to be accessed (i.e. 1 - …
kmclaughlin-arm a3a51f8
- Fix comment "This value is ignored if Count is 0" after changing
kmclaughlin-arm 4616a23
- Rename __rpld to __pld_range
kmclaughlin-arm e53af76
- Add a second builtin allowing the metadata to be passed as a single…
kmclaughlin-arm 3513fc7
- Remove Range information from Reuse Distance description
kmclaughlin-arm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the expectation for the builtin to fail compilation when this feature is not present? or be treated as a NOP? The existing
_plddocumentation suggests the latter.I guess it comes down to whether the builtin provides useful information that can be used even if RPRFM is not available (e.g. by emitting other prefetch instructions, or non-temporal accesses).
The reason I mention this is because if there's only a weak link to the underlying instruction then we'll not want to use a feature macro, but instead something that just says the builtin is available, like __ARM_PREFIX_RANGE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the existing documentation above the
_pldbuiltin applies here too, in that the range builtin should not fail when the feature is not present and is treated as a nop.