add type annotations and docstrings to devlib#715
add type annotations and docstrings to devlib#715arjpur01 wants to merge 1 commit intoARM-software:masterfrom
Conversation
|
Hi, If this requires changing the minimum supported Python version that means we need to perform a new release of both devlib and the WA project on github and PyPI before we can merge this PR. We should also check with our known users what version of Python they are currently using to ensure we provide sufficient time for any users to migrate if required before dropping support for < 3.10. |
Hi Marc, My changes dont exactly need the 3.10 version. I have modified now, to avoid the explicit dependency on the newer language features, for ex - changing imports of Literal, Protocol and TypedDict from typing_extensions instead of from typing. Still i think it is something we should pursue and move up to 3.10 in near future, but that effort can be taken up independent of this PR. Kindly review my changes and do the needful. Thanks and Regards, |
b42c7b4 to
d2f5bb8
Compare
marcbonnici
left a comment
There was a problem hiding this comment.
I still need to finish looking through the PR, however I have left some initial comments.
|
Thanks Marc, I will look into the above and make the changes. meanwhile, please continue to review the code. |
douglas-raillard-arm
left a comment
There was a problem hiding this comment.
This review covers:
devilb/_target_runner.pydevlib/collector/__init__.pydevlib/collector/dmesg.pydevlib/collector/ftrace.py
Did not have time to review the rest yet, but I'll come back to it for more rounds.
0f975c3 to
a466f4c
Compare
1151a9b to
a0c946d
Compare
Most of the files are covered, but some of the instruments and unused platforms are not augmented
Most of the files are covered, but some of the
instruments and unused platforms are not augmented Minimum Python version required change from 3.7 to 3.10 in order to support some of the annotation features