🐛 Make sure that loggers added in NewMultipleLoggers don't fail with 'No Logger Source' #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that loggers added in NewMultipleLoggers don't fail with 'No Logger Source'.
NewMultipleLoggers calls Append to add the loggers, this tries to call c.setLoggerSource but at this point the base logger hasn't had it's source set. This change makes sure that the source is set earlier in the process.
It also adds a test that initialises the loggers with NewMultipleLoggers as there wasn't a test which is why this problem was missed.
Test Coverage