Skip to content

Fix example definition of PSA_ALG_IS_SIGN_HASH() #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
athoelke merged 2 commits into from
Sep 12, 2025
Merged

Fix example definition of PSA_ALG_IS_SIGN_HASH() #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d33dac7
Fix example definition of PSA_ALG_IS_SIGN_HASH()
athoelke Sep 12, 2025
9a36388
Update copyright
athoelke Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/crypto/appendix/history.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Changes to the API
Clarifications and fixes
~~~~~~~~~~~~~~~~~~~~~~~~

* TBD
* Corrected the example implementation of `PSA_ALG_IS_SIGN_HASH()` in :secref:`appendix-specdef-values`, to exclude PureEdDSA.

Other changes
~~~~~~~~~~~~~
Expand Down
5 changes: 3 additions & 2 deletions doc/crypto/appendix/specdef_values.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.. SPDX-FileCopyrightText: Copyright 2020-2024 Arm Limited and/or its affiliates <open-source-office@arm.com>
.. SPDX-FileCopyrightText: Copyright 2020-2025 Arm Limited and/or its affiliates <open-source-office@arm.com>
.. SPDX-License-Identifier: CC-BY-SA-4.0 AND LicenseRef-Patent-license

.. _appendix-specdef-values:
Expand Down Expand Up @@ -155,7 +155,8 @@ Algorithm macros
(((alg) & 0x7f000000) == 0x06000000)

#define PSA_ALG_IS_SIGN_HASH(alg) \
PSA_ALG_IS_SIGN(alg)
(PSA_ALG_IS_SIGN(alg) && \
(alg) != PSA_ALG_PURE_EDDSA)

#define PSA_ALG_IS_SIGN_MESSAGE(alg) \
(PSA_ALG_IS_SIGN(alg) && \
Expand Down