Modified target_cfg api#620
Merged
brianesquilona merged 1 commit intoARMmbed:masterfrom Apr 16, 2019
Merged
Conversation
Contributor
brianesquilona
commented
Mar 29, 2019
brianesquilona
commented
- Array of flash and ram regions are defined
- Added flash algo, flags, alias_index for memory region
- Moved target_config.h and target_rest.h to target folder
- Modified families and bootloader file for new target_config api
Contributor
Author
|
/morph test |
brianesquilona
force-pushed
the
flash_ram_region_flags
branch
from
4077c1e to
7a98ff4
Compare
Contributor
Author
|
/morph test |
brianesquilona
force-pushed
the
flash_ram_region_flags
branch
from
dc7785d to
c3df89f
Compare
Contributor
Author
|
/morph test |
1. Array of flash and ram regions are defined 2. Added flash algo, flags, alias_index for memory region 3. Moved target_config.h and target_rest.h to target folder 4. Modified families and bootloader file for new target_config api 5. Added test filter for boards that cannot run DAPLink test 6. Update documentation for porting target family
brianesquilona
force-pushed
the
flash_ram_region_flags
branch
from
6557498 to
483b3b3
Compare
Contributor
Author
|
/morph test |
1 similar comment
Contributor
Author
|
/morph test |
| flash_start_local = g_board_info.target_cfg->flash_start; | ||
| region_info_t * region = g_board_info.target_cfg->flash_regions; | ||
| for (; region->start != 0 || region->end != 0; ++region) { | ||
| if (addr >= region->start && addr <= region->end) { |
There was a problem hiding this comment.
write_bin call this function with addr = 0, if the flash is not starting from addr 0x0 then flashing of bin format will fail, have you tested this? originally flash_start_local used to get populated everytime, but this is not the case anymore, I think the check should be "if (kRegionIsDefault == region->flags) {"
| static bool flash_decoder_is_at_end(uint32_t addr, const uint8_t *data, uint32_t size) | ||
| { | ||
| uint32_t end_addr; | ||
| uint32_t end_addr=0; |
| break; | ||
| } | ||
| } | ||
| if(end_addr == 0){ //invalid end_addr |
There was a problem hiding this comment.
if (end_addr == 0) { //invalid end_addr
spacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.