Use dir command on Windows for checking mount points
#125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you call `os.path.exists` on a removable drive that is currently in the "ejected" state (which often happens when flashing multiple devices at the same time), then an error dialog will be shown that blocks the python process until the user interacts with it. You can globally disable these error boxes, but this is undesirable as it may mask other errors that occur. Windows has APIs that allow it to check if a device is ready before accessing the file system, however this is hard to access from Python. Instead, we use the `dir` command, which will error but not cause a blocking error dialog. For other OSes, we just use `os.path.exists`.
| `dir` prevents this since it uses the Windows API to determine if the | ||
| device is ready before accessing the file system. | ||
| """ | ||
| stdout, stderr, retcode = self.run_cli_process('dir %s' % path) |
Contributor
There was a problem hiding this comment.
Does dir command behave same on all platforms? I guess it will have different behaviour on Windows and Linux.
Contributor
Author
There was a problem hiding this comment.
The dir command will only be used on Windows. On Linux it looks like it never actually checks to see if the file system has that mount point via os.path.exists, it just checks the mount point using the mount command.
Contributor
There was a problem hiding this comment.
Alright I see that it is in Windows implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call
os.path.existson a removable drive that is currently in the"ejected" state (which often happens when flashing multiple devices at the
same time), then an error dialog will be shown that blocks the python
process until the user interacts with it. You can globally disable these
error boxes, but this is undesirable as it may mask other errors that occur.
Windows has APIs that allow it to check if a device is ready before
accessing the filesystem, however this is hard to access from Python.
Instead, we use the
dircommand, which will error but not cause a blockingerror dialog.
Note: We aren't currently checking the mount point via the file system for other OSes, but I've added the base function in
lstools_base.py. If this is unnecessary I can remove this.