Skip to content

Conversation

@ConorPKeegan
Copy link
Contributor

Changes

  • Add a function to get target USB IDs for all of the connected and mounted mbed devices by their target IDs
  • Add a check for a different target ID and target USB ID when getting the COM port from target ID, and then get the COM port from the target USB ID

Fixes

@ConorPKeegan
Copy link
Contributor Author

@mazimkhan @adbridge @bridadan Can you please review this

connected_mbeds_ids = {}
for mbed in self.get_connected_mbeds():
htm_target_id = self.get_mbed_htm_target_id(mbed[0])
target_id = htm_target_id if htm_target_id else mbed[1]
Copy link
Contributor

@bridadan bridadan Sep 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the target_id logic here is duplicated from the function discover_connected_mbeds. Do you think you could break out this logic into a separate function and use it in both functions?

@bridadan
Copy link
Contributor

bridadan commented Sep 7, 2016

Thanks for looking at that @ConorPKeegan, changes look good to me.

@mazimkhan
Copy link
Contributor

LGTM

@mazimkhan mazimkhan merged commit 8793f14 into ARMmbed:master Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_mbed_com_port does not return feasible port for NUCLEO_F401RE

3 participants