Fix retargeting bug when using mbedls.json #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A NamesError exception is caused because some variables are not defined. Changes the debug output. Fixes #268.
bridadan
approved these changes
Nov 20, 2017
Contributor
bridadan
left a comment
bridadan
left a comment
There was a problem hiding this comment.
Looks great, I can confirm that this fixes the problem when running this patch locally.
@theotherjimmy This line isn't currently in our coverage, hence why this bug is being revealed now. It'd be good to get this one covered in a follow up PR.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A NamesError exception is caused because some variables are not defined.
Changes the debug output. Fixes #268.