Skip to content

Add DISCO_F303VC #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theotherjimmy merged 1 commit into from
Feb 21, 2018
Merged

Add DISCO_F303VC #304

theotherjimmy merged 1 commit into from
Feb 21, 2018

Conversation

@jeromecoutant
Copy link
Contributor

@jeromecoutant jeromecoutant commented Feb 7, 2018

@coveralls
Copy link

coveralls commented Feb 7, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 74.775% when pulling b061e11 on jeromecoutant:PR_DISCO_F303 into e9f2610 on ARMmbed:master.

bridadan
bridadan reviewed Feb 7, 2018
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Mbed DB, the platform name listed for 0746 is DISCO-F303C instead of DISCO-F303VC. It looks like the DB needs to be updated?

@jeromecoutant
Copy link
Contributor Author

jeromecoutant commented Feb 7, 2018

I can set F303C

Then I will update MBED-OS side accordingly

@bridadan
Copy link
Contributor

bridadan commented Feb 7, 2018

@jeromecoutant Your product page lists it as STM32F303VC though, won't that cause confusion?

bridadan
bridadan approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB updated, looks good

@theotherjimmy theotherjimmy merged commit 2efd5a8 into ARMmbed:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@bridadan bridadan bridadan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeromecoutant @coveralls @bridadan @theotherjimmy