Document logging behavior #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
changed the title
bridadan
approved these changes
Feb 28, 2018
README.md
Outdated
|
|
||
| ## Logging | ||
|
|
||
| Mbed LS uses the python `logging` module for all of its logging needs. Mbed LS uses the logger `"mbedls"` as its root, and all other loggers start with `"mbedls."`. Configuring the python root logger automatically redirects all of the logging done by Mbed LS to the configured endpoint. When using the python API, configure logging, such as by calling `logging.basicConfig()`. |
Contributor
There was a problem hiding this comment.
- Please capitalize "Python" all three times.
- Please change "all the logging done by Mbed LS" to "all the logging Mbed LS does" for active voice.
AnotherButler
suggested changes
Mar 1, 2018
Contributor
AnotherButler
left a comment
AnotherButler
left a comment
There was a problem hiding this comment.
Please make my suggested changes; I don't have permissions.
AnotherButler
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #302 (Docmumentation bits)
@AnotherButler Could you edit?