Skip to content

Conversation

@bridadan
Copy link
Contributor

This should fix #332.

The issue was Windows 7 PCs don't have a "volume" service. I have switched the implementation to use the "Disk" service instead. It seems to work well on Windows 10 and Windows 7.

@toyowata Would it be possible for you to test this when you get a chance? I'll be doing my own tests on my Japanese Windows 7 VM, but it'd be good to verify this on your hardware as well.

@coveralls
Copy link

coveralls commented Apr 25, 2018

Coverage Status

Coverage increased (+0.2%) to 78.287% when pulling c228d87 on bridadan:fix_windows_7 into 74979f5 on ARMmbed:master.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me.

@theotherjimmy theotherjimmy merged commit 284beb3 into ARMmbed:master Apr 25, 2018
@toyowata
Copy link
Contributor

@bridadan
Great, thanks. It works on the Windows 7.

PS C:\test\mbed-ls> mbed ls
mbed-ls (#284beb31959e)
PS C:\test\mbed-ls> pip install -U .
Processing c:\test\mbed-ls
Requirement already up-to-date: PrettyTable>=0.7.2 in c:\python27\lib\site-packages (from mbed-ls==1.4.3)
Requirement already up-to-date: fasteners in c:\python27\lib\site-packages (from mbed-ls==1.4.3)
Requirement already up-to-date: appdirs>=1.4 in c:\python27\lib\site-packages (from mbed-ls==1.4.3)
Requirement already up-to-date: monotonic>=0.1 in c:\python27\lib\site-packages (from fasteners->mbed-ls==1.4.3)
Requirement already up-to-date: six in c:\python27\lib\site-packages (from fasteners->mbed-ls==1.4.3)
Installing collected packages: mbed-ls
  Running setup.py install for mbed-ls ... done
Successfully installed mbed-ls-1.4.3
You are using pip version 9.0.1, however version 10.0.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
PS C:\test\mbed-ls> mbedls --debug
DEBUG:mbedls.main:mbed-ls ver. 1.4.3
DEBUG:mbedls.main:host: ('nt', 'Windows', '7', '6.1.7601', 'win32')
WARNING:mbedls.platform_database:Error loading database C:\Users\toywat01\AppData\Local\mbedls\mbedls\platforms.json: Platform Database is out of date; Recreating
DEBUG:mbedls.lstools_win7:_iter_vals <PyHKEY object at 0x02B7B920>
DEBUG:mbedls.lstools_win7:Mount point E: found for volume _??_USBSTOR#Disk&Ven_MBED&Prod_VFS&Rev_0.1#550000000fb1f33300000000000000000000000097969902&0#{53f56307-b6bf-11d0-94f2-00a0c91efb8b}
DEBUG:mbedls.lstools_win7:Fetching mounted devices from disk service registry entry
DEBUG:mbedls.lstools_win7:_iter_vals <PyHKEY object at 0x02B7B920>
DEBUG:mbedls.lstools_win7:Fetching usb storage devices from USBSTOR service registry entry
DEBUG:mbedls.lstools_win7:_iter_vals <PyHKEY object at 0x02B7B920>
DEBUG:mbedls.lstools_win7:target_id_usb_id -> mount_point mapping: {u'550000000fb1f33300000000000000000000000097969902': 'E:'}
DEBUG:mbedls.lstools_win7:Device SYSTEM\CurrentControlSet\Enum\USB\VID_0D28&PID_0204\550000000fb1f33300000000000000000000000097969902 did not have a "ParentIdPrefix" key, sticking with 550000000fb1f33300000000000000000000000097969902 as entry key string
DEBUG:mbedls.lstools_win7:Composite device subdevice key SYSTEM\CurrentControlSet\Enum\USB\VID_0D28&PID_0204&MI_02 was not found, skipping
DEBUG:mbedls.lstools_win7:Unknown capabilities from the following ids: [u'usb\\class_03&subclass_00&prot_00', u'usb\\class_03&subclass_00', u'usb\\class_03']
DEBUG:mbedls.lstools_win7:Composite device subdevice key SYSTEM\CurrentControlSet\Enum\USB\VID_0D28&PID_0204&MI_04 was not found, skipping
DEBUG:mbedls.lstools_base:Candidates for display [{'mount_point': 'E:', 'serial_port': u'COM38', 'target_id_usb_id': u'550000000fb1f33300000000000000000000000097969902'}]
DEBUG:mbedls.lstools_win7:Mount point E: is ready
DEBUG:mbedls.lstools_base:Found target id 550000000fb1f33300000000000000000000000097969902 in htm line window.location.replace("https://mbed.org/device/?code=550000000fb1f33300000000000000000000000097969902?version=0243?target_id=00000000000000000000000000000000");

DEBUG:mbedls.lstools_base:Found htm target id, 550000000fb1f33300000000000000000000000097969902, for usb target id 550000000fb1f33300000000000000000000000097969902
+---------------+----------------------+-------------+-------------+--------------------------------------------------+-----------------+
| platform_name | platform_name_unique | mount_point | serial_port | target_id                                        | daplink_version |
+---------------+----------------------+-------------+-------------+--------------------------------------------------+-----------------+
| RZ_A1H        | RZ_A1H[0]            | E:          | COM38       | 550000000fb1f33300000000000000000000000097969902 | 0243            |
+---------------+----------------------+-------------+-------------+--------------------------------------------------+-----------------+
DEBUG:mbedls.main:Return code: 0
PS C:\test\mbed-ls>

@bridadan
Copy link
Contributor Author

Awesome @toyowata, sorry for breaking it 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mbedls v1.4.3 doesn't detect connected targets

4 participants