Skip to content

Use delayed response when deregistering client #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2019
Merged

Use delayed response when deregistering client #31

merged 1 commit into from
Oct 2, 2019

Conversation

@anttiylitokola
Copy link
Contributor

@anttiylitokola anttiylitokola commented Oct 2, 2019

No description provided.

@teetak01 teetak01 mentioned this pull request Oct 2, 2019
Closed
@anttiylitokola anttiylitokola merged commit 54daa9f into master Oct 2, 2019
@wajahat-abbas
Copy link
Member

wajahat-abbas commented Oct 2, 2019

@teetak01 is the use of set_message_delivery_status_cb not required?

@teetak01
Copy link
Contributor

teetak01 commented Oct 2, 2019

Yes, it should also be used here, at that is the final guarantee that the message has left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teetak01 teetak01 teetak01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anttiylitokola @wajahat-abbas @teetak01