Skip to content

[feature-wisun] Update STM32 EMAC driver - limit RX frame length #12516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2020
Merged

[feature-wisun] Update STM32 EMAC driver - limit RX frame length #12516

merged 2 commits into from
Feb 28, 2020

Conversation

@artokin
Copy link
Contributor

@artokin artokin commented Feb 26, 2020 •
edited
Loading

Summary of changes

This is the same change as made in #12457 but targeted to feature branch: feature-wisun

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikaleppanen , @teetak01 , @mikter , @TuomoHautamaki

Arto Kinnunen added 2 commits February 26, 2020 13:33
Update STM32 EMAC driver - limit RX frame length
f06c93a 
DISCO_F769NI EMAC driver may return ethernet packet with illegal
length when driver is under heavy load. In one case, the received
bytes indicate frame length of 53 bytes but advertised data length
was 65518 bytes. In another case EMAC driver variable
`EthHandle.RxFrameInfos.length` contained value 0xFFFF FFFC.

As a work-around accept only 1-1500 bytes long ethernet packets.
Update STM32 EMAC driver based on review
c4fe17c 
-Fix len type
-Use ETH_RX_BUF_SIZE instead of hard-coded value 1500
@ciarmcom ciarmcom requested review from a team, mikaleppanen and teetak01 February 26, 2020 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 26, 2020

@artokin, thank you for your changes.
@teetak01 @mikaleppanen @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Feb 26, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 26, 2020

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

Client restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

Client is failing for wisun feature branch, will need help cc @ARMmbed/mbed-os-test

@artokin artokin merged commit b512574 into ARMmbed:feature-wisun Feb 28, 2020
@artokin artokin deleted the stm32_emac_driver_to_feature_wisun branch February 28, 2020 12:00
@artokin
Copy link
Contributor Author

artokin commented Feb 28, 2020

OK for the feature branch, will integrate now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mikaleppanen mikaleppanen Awaiting requested review from mikaleppanen

@teetak01 teetak01 Awaiting requested review from teetak01

Assignees

No one assigned

Labels

needs: work release-version: feature branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@artokin @ciarmcom @0xc0170 @mbed-ci @mikaleppanen @teetak01