Merging changes from ATParser towards parser unification #5205
Conversation
Instead of using #if NDEBUG, we can directly invoke debug() function. Fixes ARMmbed#5013
Release the deep sleep lock when running instances of the Timer class are deleted. This ensures that deep sleep locks are properly released by the Timer class.
As PWMOut in most cases depend on high speed freq clock, it should lock deepsleep while active.
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
Correct the vector table size on the LPC54114. This fixes crashes seen on boot when building with GCC.
…inationCallbackParams_t
Also fix wrong usage of designed initializer in CPP files.
This changes introduce a platform adaptation over ATT/GATT that can be implemented by porter. Unlike the GattClient interface, the ATT/GATT adaptation is simple, follow closely the Bluetooth specification and won't change over time. Implementation of the GattClient interface is realized by the class GenericGattClient which accept in input a pal::GattClient. This change will also free design space once adopted by partners, addition to the GattClient interface won't require partner support.
It allows mbed users to enable BLE on targets with an external BLE module.
platform/ATCmdParser.h
Outdated
| */ | ||
| void abort(); | ||
|
|
||
| /** |
|
|
||
| // Check for oob data | ||
| struct oob *oob = _oobs; | ||
| while ( oob ) { |
There was a problem hiding this comment.
I'm not seeing a formatting issue on this specific line, may be I'm missing the point, can you please give me details?
There was a problem hiding this comment.
should be while (oob) {, no spaces around conditional arguments
| _aborted = true; | ||
| } | ||
|
|
||
| bool ATCmdParser::process_oob() |
There was a problem hiding this comment.
Do you have any test code for this ? I wish to see how are you using it.
There was a problem hiding this comment.
@kjbracey-arm could you please review it ?
There was a problem hiding this comment.
This is a merge from ATParser which is already tested with ATParser, please see ARMmbed/ATParser#14
There was a problem hiding this comment.
The code that you introduced is already a part of ATCmdParser in vrecv function.
https://github.com/ARMmbed/mbed-os/blob/master/platform/ATCmdParser.cpp#L274
Why would you do that again in a separate method ?
Fix LPC54114 vector table size
Check for mbed 5 support on export
STM32: USBDevice files clean-up
Update K66F to SDK 2.2
Fix cellular APN_db.h lookup.
mts targets: fix debug() usage
BLE: Cordio port
Release deep sleep lock in destructor of Timer class
PWMOut: lock deesleep addition
…i/mbed-os into sen_ATCmdParserChanges
|
Need to close this PR and start a new one as I pushed a wrong branch by mistake. Let me push a new PR. |
|
You can force push to replace the branch and keep the pr conversation |
|
I'm not entirely sure, but I think you want to rebase and force push: # Where upstream = git@github.com:armmbed/mbed-os
git rebase --onto my-upstream/master ecebb72~ ecebb72
# Make new branch label if rebase worked
git branch -D sen_ATCmdParserChanges
git checkout -b sen_ATCmdParserChanges
# Where origin = git@github.com:SenRamakri/mbed-os
git push origin sen_ATCmdParserChanges --force |
|
Ah Sorry, Chris. too late now :-) I already push another PR. |
Merging changes from ATParser to ATCmdParser towards parser unification:
ARM Internal REF: IOTMORF-1232