Update description of rpc_fncall_waitfor() #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit that added box_id_caller to rpc_fncall_waitfor() did not also update the documentation for rpc_fncall_waitfor(). Update the description of rpc_fncall_waitfor() to include mention of box_id_caller. Fixes: 34eb5f0 ("rpc: Add box_id_caller to rpc_fncall_waitfor")
AlessandroA
reviewed
Sep 23, 2016
Contributor
AlessandroA
left a comment
AlessandroA
left a comment
There was a problem hiding this comment.
@Patater are header files comments also up to date? (I'm thinking about the doxygen-like comments)
Contributor
Author
Contributor
|
Thanks! |
AlessandroA
approved these changes
Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit that added box_id_caller to rpc_fncall_waitfor() did not also
update the documentation for rpc_fncall_waitfor(). Update the description
of rpc_fncall_waitfor() to include mention of box_id_caller.
Fixes: 34eb5f0 ("rpc: Add box_id_caller to rpc_fncall_waitfor")
@AlessandroA @niklas-arm @sherrellbc