svc: Make svc_exports.h great again #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patater
changed the title
Patater
force-pushed
the
make-svc-great-again
branch
from
35bdff0 to
4dc15af
Compare
Patater
changed the title
meriac
reviewed
Nov 10, 2016
api/inc/register_gateway.h
Outdated
| #define __UVISOR_OFFSETOF(type, member) ((uint32_t) (&(((type *)(0))->member))) | ||
|
|
||
| /** Generate the SVCall opcode from the SVC ID. */ | ||
| #define UVISOR_SVC_OPCODE(id) ((uint16_t) 0xDF00 | (uint8_t) ((id) & 0xFF)) |
Contributor
There was a problem hiding this comment.
@Patater the (uint8_t) cast in combination and the 0xFF seems to be too much - either one or the other?
Contributor
Author
There was a problem hiding this comment.
This matches what we had before. I'm just moving it between files now. (It was in core/system/inc/svc.h)
Contributor
There was a problem hiding this comment.
That doesn't answer my question
Contributor
Author
There was a problem hiding this comment.
I added a commit to remove the extra casts from UVISOR_SVC_OPCODE.
We don't need the uint8_t cast. Performing a bitwise and with 0xFF is good enough to force the range of values `id` can become. Remove the uint8_t cast. Keep the uint16_t cast, as the opcode should be seen as a uint16_t.
Patater
force-pushed
the
make-svc-great-again
branch
from
4dc15af to
5b7aae2
Compare
Removing svc_exports.h broke the register-level gateway. Re-create svc_exports.h with just the minimum needed to make the register-level gateway work again. Fixes: f51198c ("Expose all uVisor API via a function table")
Patater
force-pushed
the
make-svc-great-again
branch
from
5b7aae2 to
a7ce44c
Compare
Contributor
Author
|
Tests pass on EFM32. |
AlessandroA
approved these changes
Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing svc_exports.h broke the register-level gateway. Re-create
svc_exports.h with just the minimum needed to make the register-level
gateway work again.
Fixes: f51198c ("Expose all uVisor API via a function table")
@AlessandroA @meriac @niklas-arm