Fix disabled shipped personas fallback#39
Draft
dogxii wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thanks for picking up #31 @dogxii. The core fix is correct, and I especially like the extra test that loads Before this is ready to merge, a few things in the same PR please:
Also note there’s an overlapping PR (#34) for the same issue, once yours is updated and marked ready, we’ll merge one and close the other since no one claimed this issue, it will be first come first serve. Thanks again! and if you wanna take your time in solving issues, please feel free to comment under them in your next contributions, so issues can be specifically assigned to you, and we avoid overlapping PRs. <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_shipped_personas: falsewhen no YAML personas are configured.personaskey.Closes #31.
Validation
PYTHONPATH=. venv/bin/python -m pytest tests/test_settings.py -qPYTHONPATH=. venv/bin/python -m pytest tests/test_settings.py tests/test_cli_settings_smoke.py tests/test_cli.py -qPYTHONPATH=. venv/bin/python -m pytest tests/ -qvenv/bin/python -m flake8 rooms/settings.py tests/test_settings.py --count --select=E9,F63,F7,F82 --show-source --statisticsvenv/bin/python -m flake8 rooms/settings.py tests/test_settings.py --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics