fix(issue_resolver): replace wide emoji regex for CodeQL py/overly-large-range#146
Merged
Merged
Conversation
…rge-range Use explicit Unicode code-point ranges in validate_commit_message instead of a single large regex span flagged on main after ARPAHLS#144.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hotfix for CodeQL alert #3 on
mainafter #144.validate_commit_messageused a single wide regex span (\U0001F300-\U0001FAFF) to detect emojis in commit subjects. CodeQL rulepy/overly-large-rangeflags that pattern as overly permissive (character-class range may match unintended code points).Change: replace
EMOJI_PATTERNregex with explicit Unicode code-point ranges and a small_contains_emoji()helper. Behavior unchanged — commit subjects with emojis are still rejected. No API or manifest changes.Closes CodeQL alert #3 when merged and rescanned.
Type of Change (Matches Issue Templates)
Checklist (all PRs)
python -m flake8 .andpytest tests/locally (or the subset relevant to this change).CHANGELOG.mdupdated under[Unreleased]if this PR changes user-visible behavior — not required; internal implementation detail onlyexamples/README.mdis updated — N/ANew or updated skill
Skip — hotfix touches one helper in
workflow.pyonly; no metadata, docs, or example changes.Constitution & Safety
Related Issues
EMOJI_PATTERNinworkflow.py)py/overly-large-range)