-
Notifications
You must be signed in to change notification settings - Fork 7
Features/parallelized heliostat groups #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
- Coverage 98.31% 97.62% -0.70%
==========================================
Files 32 32
Lines 1840 1933 +93
==========================================
+ Hits 1809 1887 +78
- Misses 31 46 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalebphipps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for the changes!
for more information, see https://pre-commit.ci
…groups' into features/parallelized_heliostat_groups # Conflicts: # artist/util/environment_setup.py
Parallelized heliostat groups
I have changed the distributed environment setup, it is now possible to have nested distributed process groups.
Up until now the individual heliostat groups were processed sequentially one after the other. Within the heliostat groups it was possible to process heliostats in parallel using DDP. With the nested distributed setup heliostat groups are processed in parallel and the parallelisation within each group remains.
I have also changed the logging, most statements will now only be logged from rank 0.
Fixes #125
Type of change
Checklist: