[bug] fix TLS tests workflow#3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the SSL certificate generation process in the CI end-to-end workflow to include an additional DNS entry for
custom-spu-5001.localhostin the server certificate. This change ensures that the generated certificate is valid for bothlocalhostandcustom-spu-5001.localhost, which are required for testing locally, since records are consumed from the SPU, which recieves a separate subdomain to the SC.Using this fix, the tests pass on my local machine and in the checks for my fork, so the same should be true for the original repository. No changes to the main code have been made.