Skip to content

Update @asu/component-events npm package to v3.0.1#246

Merged
jkcox merged 7 commits into
developfrom
copilot/update-asu-events-components
Dec 4, 2025
Merged

Update @asu/component-events npm package to v3.0.1#246
jkcox merged 7 commits into
developfrom
copilot/update-asu-events-components

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 1, 2025

Updates the @asu/component-events npm package dependency from version 2.0.3 to 3.0.1.

Changes

  • Updated package.json: @asu/component-events from ^2.0.3 to ^3.0.1

Architecture

The asu-events block imports the component from the npm package:

import { CardsGridEvents } from "@asu/component-events/dist/asuEvents.es";

KE-specific integrations remain unchanged:

  • component-ke-events: KE GraphQL events (used by events-grid block)
  • component-news: KE WordPress REST API news (used by news-grid block)

The minimal source files in resources/unity/component-events/src (styles and types) remain for reference but are not directly imported by any blocks.

Original prompt

This section details on the original issue you should resolve

<issue_title>ASU Events - update to latest</issue_title>
<issue_description>The react components of the asu events block need to be updated.
Get the updated components from https://github.com/ASU/asu-unity-stack/tree/dev/packages/component-events
Merge the files into resources/unity, be sure not to overwrite the custom changes that allow the news component to function with KE news service. If there is a conflict ask me to resolve.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits December 1, 2025 17:29
Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
Copilot AI changed the title [WIP] Update ASU Events block to latest components Update ASU Events components to v3.0.1 Dec 1, 2025
Copilot AI requested a review from jkcox December 1, 2025 17:35
@jkcox jkcox marked this pull request as ready for review December 3, 2025 17:41
@jkcox
Copy link
Copy Markdown
Contributor

jkcox commented Dec 3, 2025

@copilot >Added 19 component files previously missing from resources/unity/component-events/src

which gutenberg blocks use these files?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Dec 3, 2025

@copilot >Added 19 component files previously missing from resources/unity/component-events/src

which gutenberg blocks use these files?

None of the Gutenberg blocks directly use the files in resources/unity/component-events/src.

The asu-events block imports from the npm package @asu/component-events/dist/asuEvents.es (which I updated to v3.0.1 in package.json).

The events-grid block uses the separate KE custom implementation from resources/unity/component-ke-events/src/.

The files I added to resources/unity/component-events/src are source files that correspond to the npm package v3.0.1, but they're not directly imported by any blocks in this repository.

@jkcox
Copy link
Copy Markdown
Contributor

jkcox commented Dec 3, 2025

@copilot >Added 19 component files previously missing from resources/unity/component-events/src
which gutenberg blocks use these files?

None of the Gutenberg blocks directly use the files in resources/unity/component-events/src.

The asu-events block imports from the npm package @asu/component-events/dist/asuEvents.es (which I updated to v3.0.1 in package.json).

The events-grid block uses the separate KE custom implementation from resources/unity/component-ke-events/src/.

The files I added to resources/unity/component-events/src are source files that correspond to the npm package v3.0.1, but they're not directly imported by any blocks in this repository.

delete the files if they are unused

@jkcox jkcox added [Type] Maintenance Minor file cleanup and organization tasks javascript Pull requests that update Javascript code labels Dec 3, 2025
Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Dec 3, 2025

@copilot >Added 19 component files previously missing from resources/unity/component-events/src
which gutenberg blocks use these files?

...

Deleted the 19 unused source files. Only the original 5 files remain in resources/unity/component-events. The asu-events block continues to use the npm package @asu/component-events v3.0.1. (97b2f84)

Copilot AI changed the title Update ASU Events components to v3.0.1 Update @asu/component-events npm package to v3.0.1 Dec 3, 2025
@jkcox jkcox requested review from wmcconnell and zainabD December 3, 2025 22:11
Copy link
Copy Markdown
Contributor

@wmcconnell wmcconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some quick testing just to make sure nothing changing on the inside broke anything on the outside the following all still work on this branch:

  • Change header color
  • Change Header text
  • Toggle header on/off
  • Change Data Source URL
  • Change Filters
  • Actually displaying the correct events

Changing the message used when no events are found does not work, but it has nothing to do with the changes in this PR as it does not work on main either. I think we may be modifying a prop that isn't actually used/doesn't exist.

Approved.

@jkcox jkcox merged commit b3070cc into develop Dec 4, 2025
@jkcox jkcox deleted the copilot/update-asu-events-components branch December 4, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code [Type] Maintenance Minor file cleanup and organization tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ASU Events - update to latest

3 participants