Update @asu/component-events npm package to v3.0.1#246
Conversation
Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
|
@copilot >Added 19 component files previously missing from resources/unity/component-events/src which gutenberg blocks use these files? |
None of the Gutenberg blocks directly use the files in The The The files I added to |
delete the files if they are unused |
Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
... Deleted the 19 unused source files. Only the original 5 files remain in resources/unity/component-events. The asu-events block continues to use the npm package @asu/component-events v3.0.1. (97b2f84) |
wmcconnell
left a comment
There was a problem hiding this comment.
Did some quick testing just to make sure nothing changing on the inside broke anything on the outside the following all still work on this branch:
- Change header color
- Change Header text
- Toggle header on/off
- Change Data Source URL
- Change Filters
- Actually displaying the correct events
Changing the message used when no events are found does not work, but it has nothing to do with the changes in this PR as it does not work on main either. I think we may be modifying a prop that isn't actually used/doesn't exist.
Approved.
Updates the
@asu/component-eventsnpm package dependency from version 2.0.3 to 3.0.1.Changes
@asu/component-eventsfrom^2.0.3to^3.0.1Architecture
The
asu-eventsblock imports the component from the npm package:KE-specific integrations remain unchanged:
component-ke-events: KE GraphQL events (used byevents-gridblock)component-news: KE WordPress REST API news (used bynews-gridblock)The minimal source files in
resources/unity/component-events/src(styles and types) remain for reference but are not directly imported by any blocks.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.