v3.1 - ranking card

[jkcox]

https://asu.github.io/asu-unity-stack/@asu/unity-react-core/index.html?path=/docs/components-ranking-card--docs

[jkcox]

@copilot
list of props: https://asu.github.io/asu-unity-stack/@asu/unity-react-core/index.html?path=/docs/components-ranking-card--docs

• update attributes in block.json
• update edit.js
• update frontend.js
• update inspector.js
• update save.js

[Copilot]

@jkcox I've opened a new pull request, #259, to work on those changes. Once the pull request is ready, I'll request review from you.

[jkcox]

tested locally

[wmcconnell]

Adding this comment here to record information from the Zoom meeting I had with John during the working session today:

• The Ranking Cards, in my testing, work just fine and match the standards shown here
• However, the data layer attributes, such as data-ga-section, etc., are not showing up on the Ranking Card where they should, which is:
  • The button/title that triggers the slide up effect
  • The "Read more" link that appears within the exposed content after it slides up
    • Fun fact: that 'Read more' link does not appear to have any aria-label or aria-labelledby attributes, which a generic link like 'Read more' should have, I believe
• This is despite the fact that there is some code in there to establish defaults and render those data layer attributes in both the places mentioned above
• That code, however, utilizes a couple of components, GaEventWrapper and useBaseSpecificFramework that tries to determine (I think) if the component is being rendered "for real" or as Bootstrap HTML. I think this may be to avoid analytics stuff firing in Storybook or wherever, but it may also be preventing the rendering of the data-ga attributes for us as well
• I tried to trace this in the Unity source code and figure it out, but I wasn't smart enough. I can give it another try but I have already suggested to John to ask CoPilot whey this is happening (which I might do as well)
• The full, expected HTML output of this block is available! Right here, in fact.
• That means that, if we can't figure out what's happening here, we could craft an ACF powered block using that HTML and ensure that we can have the correct data layer attributes. Copying and pasting that exact HTML into a customHTML block while on John's branch produced a fully functional (and perhaps better functioning) Ranking Card

Since @jkcox is already aware of our conversation, I'm not leaving this as a formal review with 'Request Changes,` because that makes things slightly more annoying; it would require a request for another review. It does raise the question of whether or not I should do that, however.