Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions build/anchor-menu/block.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"$schema": "https://schemas.wp.org/trunk/block.json",
"apiVersion": 2,
"apiVersion": 3,
"name": "unityblocks/anchor-menu",
"version": "2.1.0",
"version": "3.0.0",
"title": "Unity Anchor Menu",
"category": "unityblocks",
"keywords": [
Expand All @@ -21,7 +21,6 @@
},
"textdomain": "unityblocks",
"viewScript": [
"file:./frontend.js",
"unityblocks-anchor-menu-view-script"
],
"editorScript": "file:./index.js",
Expand Down
1 change: 0 additions & 1 deletion build/anchor-menu/frontend.asset.php

This file was deleted.

39 changes: 0 additions & 39 deletions build/anchor-menu/frontend.js

This file was deleted.

2 changes: 1 addition & 1 deletion build/anchor-menu/index.asset.php
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '8e561850cdf8964bb460');
<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '4591e447e8128374e237');
7 changes: 2 additions & 5 deletions build/anchor-menu/index.js

Large diffs are not rendered by default.

16 changes: 12 additions & 4 deletions build/blocks-manifest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
return array(
'anchor-menu' => array(
'$schema' => 'https://schemas.wp.org/trunk/block.json',
'apiVersion' => 2,
'apiVersion' => 3,
'name' => 'unityblocks/anchor-menu',
'version' => '2.1.0',
'version' => '3.0.0',
'title' => 'Unity Anchor Menu',
'category' => 'unityblocks',
'keywords' => array(
Expand All @@ -24,7 +24,6 @@
),
'textdomain' => 'unityblocks',
'viewScript' => array(
'file:./frontend.js',
'unityblocks-anchor-menu-view-script'
),
'editorScript' => 'file:./index.js',
Expand Down Expand Up @@ -515,7 +514,7 @@
'$schema' => 'https://schemas.wp.org/trunk/block.json',
'apiVersion' => 3,
'name' => 'unityblocks/news-grid',
'version' => '2.1.0',
'version' => '2.2.0',
'title' => 'Unity News Grid',
'category' => 'unityblocks',
'keywords' => array(
Expand Down Expand Up @@ -548,6 +547,15 @@
)
),
'attributes' => array(
'displayType' => array(
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is related to news grid - looks like it was missed when the block manifest feature was added in v3.1.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkcox

I saw this and decided to put a News Grid on the page I was using to test the Anchor Menu, since I'm paranoid about them all suddenly failing to work. It worked in the editor, but failed to show up on the front-end. This error was in the console: TypeError: undefined is not an object (evaluating 'globalThis.process.env.NODE_ENV').

However, building a new page with similar elements (anchor menu, news grid, and tablets) worked just fine. So I decided to copy the content verbatim from my bad page to the new one. The News Grid did not work there either.

You know what fixed it? Renaming the anchor I had called 'process' to something else. Only seems to affect the News Grid front-end display. Weird. Likely not related to Anchor Menu updates, as it existed before. Which is to say, don't close the 'process' issue just yet.

'type' => 'string',
'enum' => array(
'grid',
'list',
'carousel'
),
'default' => 'grid'
),
'enableHeader' => array(
'type' => 'boolean',
'default' => true
Expand Down
Loading