-
Notifications
You must be signed in to change notification settings - Fork 0
v3.2 anchor menu #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v3.2 anchor menu #271
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0bbb508
latest resources
jkcox 1368538
UDS alias, error details
jkcox f1025e2
v3.2 anchor menu
jkcox f9224a7
v3.2, react override
jkcox 0f4fda8
update api, viewScript
jkcox 71db980
update import
jkcox 5bab947
update import, rm custom sticky onScroll, set bool
jkcox 1ed8a11
set id init
jkcox 83392a0
firstElementId refactor
jkcox 977b862
fix camelcase, use createRoot
jkcox 6275d50
rm comments
jkcox a625316
build latest
jkcox 73d633e
restore sticky onScroll
jkcox f8a7223
Initial plan
Copilot 4acc9ac
Refactor anchor menu render() to use UDS Bootstrap HTML
Copilot 459aac9
Refactor save.js: empty target div + unityReactCore.initAnchorMenu() …
Copilot ca16e99
Rewrite save.js to UDS Bootstrap HTML per docs; clear frontend.js
Copilot 826a2aa
Merge pull request #279 from ASU-KE/copilot/sub-pr-271
jkcox e4aff48
rm unused viewScript files
jkcox 7cbae19
rm unused file
jkcox 32ca4d7
rm get anchor custom script
jkcox be30bef
build latest v3.0 - html bootstrap version
jkcox 04d8813
build latest manifest - anchor menu update
jkcox 6c78bb3
update data-ga section
jkcox ace560c
build latest - data-ga section update
jkcox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| <?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '8e561850cdf8964bb460'); | ||
| <?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '4591e447e8128374e237'); |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is related to news grid - looks like it was missed when the block manifest feature was added in v3.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkcox
I saw this and decided to put a News Grid on the page I was using to test the Anchor Menu, since I'm paranoid about them all suddenly failing to work. It worked in the editor, but failed to show up on the front-end. This error was in the console:
TypeError: undefined is not an object (evaluating 'globalThis.process.env.NODE_ENV').However, building a new page with similar elements (anchor menu, news grid, and tablets) worked just fine. So I decided to copy the content verbatim from my bad page to the new one. The News Grid did not work there either.
You know what fixed it? Renaming the anchor I had called 'process' to something else. Only seems to affect the News Grid front-end display. Weird. Likely not related to Anchor Menu updates, as it existed before. Which is to say, don't close the 'process' issue just yet.