Skip to content

v4.1 update#315

Merged
jkcox merged 20 commits into
mainfrom
develop
Apr 24, 2026
Merged

v4.1 update#315
jkcox merged 20 commits into
mainfrom
develop

Conversation

@jkcox
Copy link
Copy Markdown
Contributor

@jkcox jkcox commented Apr 24, 2026

dependabot Bot and others added 20 commits April 10, 2026 22:00
Bumps [basic-ftp](https://github.com/patrickjuchli/basic-ftp) from 5.2.1 to 5.2.2.
- [Release notes](https://github.com/patrickjuchli/basic-ftp/releases)
- [Changelog](https://github.com/patrickjuchli/basic-ftp/blob/master/CHANGELOG.md)
- [Commits](patrickjuchli/basic-ftp@v5.2.1...v5.2.2)

---
updated-dependencies:
- dependency-name: basic-ftp
  dependency-version: 5.2.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.11 to 1.16.0.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.11...v1.16.0)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-version: 1.16.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.3.2 to 3.4.0.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.3.2...3.4.0)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.4.0
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
…file

Add .github/copilot-instructions.md for cloud agent onboarding
Expanded project documentation with detailed sections on repository layout, block architecture, build & development processes, and guidelines for making changes.
Enhance README with project details and guidelines
…-5.2.2

Bump basic-ftp from 5.2.1 to 5.2.2
…directs-1.16.0

Bump follow-redirects from 1.15.11 to 1.16.0
…-3.4.0

Bump dompurify from 3.3.2 to 3.4.0
…endered fields with String()

Agent-Logs-Url: https://github.com/ASU-KE/UnityBlocks/sessions/881c5bb8-2ff7-44a0-9b06-de9ffc7334ae

Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
Fix wchm crash for units returning non-array API responses and improve UX
v4.1 - wchm - use email alias, fix non-array API responses, loading state UX
@jkcox jkcox self-assigned this Apr 24, 2026
@jkcox jkcox added the [Priority] Critical This issue/pull request needs resolving immediately, likely followed by a hot-fix label Apr 24, 2026
@jkcox jkcox requested a review from Copilot April 24, 2026 16:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates UnityBlocks to v4.1 and improves the WCHM (Who Can Help Me) block’s resilience/UX when API responses are not arrays, alongside dependency bumps and expanded project documentation.

Changes:

  • Bump plugin version to 4.1.0 and update DOMPurify (plus lockfile transitive updates).
  • Harden WCHM autocomplete/contact fetching against non-array responses; consolidate fetches and add loading/empty states.
  • Refresh committed build artifacts and expand README; add repo-specific Copilot instructions.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
unityblocks.php Plugin header version bump to 4.1.0.
src/wchm/components/autoComplete.js Adds array guards, consolidated fetching with loading/empty UI, and email rendering changes.
package.json Bumps dompurify devDependency to ^3.4.0.
package-lock.json Updates lockfile for DOMPurify and other transitive dependency changes.
build/wchm/index.js Rebuilt editor bundle reflecting WCHM source updates.
build/wchm/index.asset.php Updates asset hash/version for rebuilt editor bundle.
build/wchm/frontend.js Rebuilt frontend bundle reflecting WCHM source updates.
build/wchm/frontend.asset.php Updates asset hash/version for rebuilt frontend bundle.
README.md Replaces minimal dev notes with comprehensive repo/build/docs guidance.
.github/copilot-instructions.md Adds Copilot guidance mirroring repository conventions and build notes.
Comments suppressed due to low confidence (1)

src/wchm/components/autoComplete.js:260

  • Officer rendering still uses contactInfo.userID to decide whether to display the title/email vs the fallback. Since the mailto now uses contactInfo.email, records with an email but no userID will render only the name (and the fallback won’t trigger if userID is undefined rather than null). Consider switching these conditions/keys to rely on email (or explicitly handle both null and undefined).
                  key={`officer-${contactInfo.userID || contactInfo.contactFullName || index}`}
                >
                  <h4 className="mb-1">{String(contactInfo.contactFullName || "")}</h4>
                  {contactInfo.userID && (
                    <>
                      <p className="mb-1">{String(contactInfo.title || "")}</p>
                      <p>
                        <a href={`mailto:${String(contactInfo.email || "")}`}>
                          {String(contactInfo.email || "")}
                        </a>
                      </p>
                    </>
                  )}

                  {contactInfo.userID === null && (
                    <>
                      <p>Proposal and PreAward Items </p>

Comment thread src/wchm/components/autoComplete.js
Comment thread src/wchm/components/autoComplete.js
Comment thread src/wchm/components/autoComplete.js
@jkcox jkcox added [Type] Enhancement Something new that adds functionality [Type] Docs Relevant improving documention labels Apr 24, 2026
@jkcox jkcox merged commit a1ccc6c into main Apr 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Priority] Critical This issue/pull request needs resolving immediately, likely followed by a hot-fix [Type] Docs Relevant improving documention [Type] Enhancement Something new that adds functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants