Conversation
Bumps [basic-ftp](https://github.com/patrickjuchli/basic-ftp) from 5.2.1 to 5.2.2. - [Release notes](https://github.com/patrickjuchli/basic-ftp/releases) - [Changelog](https://github.com/patrickjuchli/basic-ftp/blob/master/CHANGELOG.md) - [Commits](patrickjuchli/basic-ftp@v5.2.1...v5.2.2) --- updated-dependencies: - dependency-name: basic-ftp dependency-version: 5.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Agent-Logs-Url: https://github.com/ASU-KE/UnityBlocks/sessions/523f96dc-6255-409f-81d4-d4d8c55fd854 Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.11 to 1.16.0. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.11...v1.16.0) --- updated-dependencies: - dependency-name: follow-redirects dependency-version: 1.16.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.3.2 to 3.4.0. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.3.2...3.4.0) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…file Add .github/copilot-instructions.md for cloud agent onboarding
Expanded project documentation with detailed sections on repository layout, block architecture, build & development processes, and guidelines for making changes.
Enhance README with project details and guidelines
…-5.2.2 Bump basic-ftp from 5.2.1 to 5.2.2
…directs-1.16.0 Bump follow-redirects from 1.15.11 to 1.16.0
…-3.4.0 Bump dompurify from 3.3.2 to 3.4.0
…endered fields with String() Agent-Logs-Url: https://github.com/ASU-KE/UnityBlocks/sessions/881c5bb8-2ff7-44a0-9b06-de9ffc7334ae Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ASU-KE/UnityBlocks/sessions/dc36c8eb-9a83-46e1-ae16-ddf0139d4aa7 Co-authored-by: jkcox <8856538+jkcox@users.noreply.github.com>
Fix wchm crash for units returning non-array API responses and improve UX
v4.1 - wchm - use email alias, fix non-array API responses, loading state UX
There was a problem hiding this comment.
Pull request overview
Updates UnityBlocks to v4.1 and improves the WCHM (Who Can Help Me) block’s resilience/UX when API responses are not arrays, alongside dependency bumps and expanded project documentation.
Changes:
- Bump plugin version to 4.1.0 and update DOMPurify (plus lockfile transitive updates).
- Harden WCHM autocomplete/contact fetching against non-array responses; consolidate fetches and add loading/empty states.
- Refresh committed build artifacts and expand README; add repo-specific Copilot instructions.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| unityblocks.php | Plugin header version bump to 4.1.0. |
| src/wchm/components/autoComplete.js | Adds array guards, consolidated fetching with loading/empty UI, and email rendering changes. |
| package.json | Bumps dompurify devDependency to ^3.4.0. |
| package-lock.json | Updates lockfile for DOMPurify and other transitive dependency changes. |
| build/wchm/index.js | Rebuilt editor bundle reflecting WCHM source updates. |
| build/wchm/index.asset.php | Updates asset hash/version for rebuilt editor bundle. |
| build/wchm/frontend.js | Rebuilt frontend bundle reflecting WCHM source updates. |
| build/wchm/frontend.asset.php | Updates asset hash/version for rebuilt frontend bundle. |
| README.md | Replaces minimal dev notes with comprehensive repo/build/docs guidance. |
| .github/copilot-instructions.md | Adds Copilot guidance mirroring repository conventions and build notes. |
Comments suppressed due to low confidence (1)
src/wchm/components/autoComplete.js:260
- Officer rendering still uses
contactInfo.userIDto decide whether to display the title/email vs the fallback. Since the mailto now usescontactInfo.email, records with anemailbut nouserIDwill render only the name (and the fallback won’t trigger ifuserIDisundefinedrather thannull). Consider switching these conditions/keys to rely onemail(or explicitly handle bothnullandundefined).
key={`officer-${contactInfo.userID || contactInfo.contactFullName || index}`}
>
<h4 className="mb-1">{String(contactInfo.contactFullName || "")}</h4>
{contactInfo.userID && (
<>
<p className="mb-1">{String(contactInfo.title || "")}</p>
<p>
<a href={`mailto:${String(contactInfo.email || "")}`}>
{String(contactInfo.email || "")}
</a>
</p>
</>
)}
{contactInfo.userID === null && (
<>
<p>Proposal and PreAward Items </p>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.