fix(app-rfi): ga track default disabled for pii #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlsamuelson
reviewed
Jan 30, 2025
| import { useRfiContext } from "./rfiContext"; | ||
|
|
||
| export { gaEventPropTypes } from "../../../../../shared"; | ||
|
|
Member
There was a problem hiding this comment.
I'd love to see a reference to UDS-1943 added here, to highlight the importance of why this is here.
// UDS-1943 : allow some fields to be exempted from data layer
mlsamuelson
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not send any PII data to GA
I had to go back in history to check if form submission ever sent the complete form to GA and it doesn't look like any data is pushed, There is an event on submission but it is only tracking that the form was submitted
History:
asu-unity-stack/packages/app-rfi/src/components/stepper/RfiMainForm.js
Line 97 in 23671d9
Links
FOR APPROVERS