Skip to content

fix(app-rfi): ga track default disabled for pii #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2025
Merged

fix(app-rfi): ga track default disabled for pii #1454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e8c24f
fix(app-rfi): ga track default disabled for pii
scott-williams-az Jan 30, 2025
41aac68
fix(app-rfi): ga track default disabled for pii
scott-williams-az Jan 30, 2025
1ca1c1e
Revert "fix(app-rfi): ga track default disabled for pii"
scott-williams-az Jan 30, 2025
ca8207e
Revert "fix(app-rfi): ga track default disabled for pii"
scott-williams-az Jan 30, 2025
9bef080
fix(app-rfi): prevent sending pii to data layer
scott-williams-az Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/app-rfi/src/components/steps/questions/Country.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
import { fetchCountries } from "../../../core/utils/fetchCountries";
import { useRfiContext } from "../../../core/utils/rfiContext";
import { RfiSelect } from "../../controls";
import { PII_VALUE } from "../../../core/utils/constants";

// Options
function getCountryOptions(resultsArrayOfObjects) {
Expand Down Expand Up @@ -56,7 +57,7 @@ export const Country = ({ gaData }) => {
...gaData,
event: "select",
type: label,
text: e.target.selectedOptions[0].innerText,
text: PII_VALUE,
})
}
/>
Expand Down
3 changes: 2 additions & 1 deletion packages/app-rfi/src/components/steps/questions/EmailAddress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from "react";

import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
import { RfiEmailInput } from "../../controls";
import { PII_VALUE } from "../../../core/utils/constants";

/**
* @param {{ gaData: import("../../../../../../shared/services/googleAnalytics").GAEventObject}} props
Expand All @@ -21,7 +22,7 @@ export const EmailAddress = ({ gaData }) => {
trackGAEvent({
...gaData,
type: label,
text: e.target.value,
text: PII_VALUE,
})
}
/>
Expand Down
3 changes: 2 additions & 1 deletion packages/app-rfi/src/components/steps/questions/FirstName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from "react";

import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
import { RfiTextInput } from "../../controls";
import { PII_VALUE } from "../../../core/utils/constants";

/**
* @param {{ gaData: import("../../../../../../shared/services/googleAnalytics").GAEventObject}} props
Expand All @@ -21,7 +22,7 @@ export const FirstName = ({ gaData }) => {
trackGAEvent({
...gaData,
type: label,
text: e.target.value,
text: PII_VALUE,
})
}
/>
Expand Down
3 changes: 2 additions & 1 deletion packages/app-rfi/src/components/steps/questions/LastName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from "react";

import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
import { RfiTextInput } from "../../controls";
import { PII_VALUE } from "../../../core/utils/constants";

/**
* @param {{ gaData: import("../../../../../../shared/services/googleAnalytics").GAEventObject}} props
Expand All @@ -21,7 +22,7 @@ export const LastName = ({ gaData }) => {
trackGAEvent({
...gaData,
type: label,
text: e.target.value,
text: PII_VALUE,
})
}
/>
Expand Down
3 changes: 2 additions & 1 deletion packages/app-rfi/src/components/steps/questions/Phone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from "react";

import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
import { RfiPhone } from "../../controls";
import { PII_VALUE } from "../../../core/utils/constants";

/**
* @param {{ gaData: import("../../../../../../shared/services/googleAnalytics").GAEventObject}} props
Expand All @@ -21,7 +22,7 @@ export const Phone = ({ gaData }) => {
trackGAEvent({
...gaData,
type: label,
text: e.target.value,
text: PII_VALUE,
})
}
/>
Expand Down
4 changes: 2 additions & 2 deletions packages/app-rfi/src/components/steps/questions/ZipCode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { useEffect } from "react";

import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
import { KEY } from "../../../core/utils/constants";
import { KEY, PII_VALUE } from "../../../core/utils/constants";
import { useRfiContext } from "../../../core/utils/rfiContext";
import { RfiTextInput } from "../../controls";

Expand Down Expand Up @@ -42,7 +42,7 @@ export const ZipCode = ({ gaData }) => {
trackGAEvent({
...gaData,
type: label,
text: e.target.value,
text: PII_VALUE,
})
}
/>
Expand Down
4 changes: 4 additions & 0 deletions packages/app-rfi/src/core/utils/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,7 @@ export const DATA_SOURCE = {
ASU_ONLINE: "https://cms.asuonline.asu.edu/lead-submissions-v3.5/programs",
COUNTRIES_STATES: "https://api.myasuplat-dpl.asu.edu/api/codeset/countries",
};

// Personally Identifiable Information (PII)
// UDS-1943 : Fields containing PII should not send the PII to data layer
export const PII_VALUE = "REDACTED";