Skip to content

fix(unity-bootstrap-theme): changed height to min-height on hero-overlay classes #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

fix(unity-bootstrap-theme): changed height to min-height on hero-overlay classes #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1b2991
fix(unity-bootstrap-theme): changed height to min-height on hero-over…
juanmitriatti Feb 10, 2025
0e0c04b
feat(unity-bootstrap-theme): changed heigth to min-heigth on div.uds-…
juanmitriatti Feb 17, 2025
64002b9
fix(unity-bootstrap-theme): added style for small and medium hero
juanmitriatti Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ div[class^="uds-hero"] {
grid-row: 2;
grid-template-columns: 1fr;
grid-template-rows: 1fr 1fr;
margin-top: $uds-size-spacing-10;

p {
margin: 0;
Expand Down Expand Up @@ -211,7 +212,7 @@ div[class^="uds-hero"] {
}

div.uds-hero-sm {
height: $uds-size-spacing-32;
min-height: $uds-size-spacing-32;
grid-template-rows: 1fr auto auto 3rem;

h1,
Expand Down Expand Up @@ -244,7 +245,7 @@ div.uds-hero-sm {
}

.hero-overlay {
height: $uds-size-spacing-32;
min-height: $uds-size-spacing-32;
}
}

Expand All @@ -254,7 +255,7 @@ div.uds-hero-sm {
}

div.uds-hero-md {
height: 21rem;
min-height: 21rem;
// by design, the hero-md has no content on mobile, change grid template rows and hide .content
grid-template-rows: 1fr auto auto 3rem;

Expand All @@ -270,7 +271,7 @@ div.uds-hero-md {
}

.hero-overlay {
height: 21rem;
min-height: 21rem;
}
}

Expand All @@ -281,7 +282,7 @@ div.uds-hero-md {
}

div.uds-hero-lg {
height: $uds-size-spacing-64;
min-height: $uds-size-spacing-64;

.content {
display: none;
Expand All @@ -307,7 +308,7 @@ div.uds-hero-lg {
}

.hero-overlay {
height: $uds-size-spacing-64;
min-height: $uds-size-spacing-64;
}
}

Expand Down Expand Up @@ -378,7 +379,7 @@ div.uds-hero-lg {
grid-template-rows: 1fr auto auto $uds-size-spacing-7;
&.has-btn-row {
.btn-row {
top: 14.5rem;
top: 92%;
}
}

Expand All @@ -390,7 +391,7 @@ div.uds-hero-lg {
}

div.uds-hero-md {
height: $uds-size-spacing-64;
min-height: $uds-size-spacing-64;
// TODO; remove this, it's a fallback for buttons without has-btn-row
grid-template-rows: 1fr repeat(4, auto) $uds-size-spacing-6;
h1 {
Expand Down Expand Up @@ -419,13 +420,13 @@ div.uds-hero-lg {
}

.hero-overlay {
height: $uds-size-spacing-64;
min-height: $uds-size-spacing-64;
}
}
}

div.uds-hero-lg {
height: 42.75rem;
min-height: 42.75rem;
// TODO; remove this, it's a fallback for buttons without has-btn-row
grid-template-rows: 1fr repeat(4, auto) $uds-size-spacing-6;

Expand All @@ -448,7 +449,7 @@ div.uds-hero-lg {
}

.hero-overlay {
height: 42.75rem;
min-height: 42.75rem;
}
}

Expand Down Expand Up @@ -497,7 +498,7 @@ div.uds-hero-lg {
}

div.uds-hero-lg {
height: 42.75rem;
min-height: 42.75rem;

&.uds-video-hero {
position: relative;
Expand Down
6 changes: 3 additions & 3 deletions packages/unity-bootstrap-theme/src/scss/extends/_xx_Hero-Competing.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,18 @@ div[class^='uds-hero'] {
}

&.uds-hero-sm {
height: $uds-size-spacing-32;
min-height: $uds-size-spacing-32;
.hero-body {
display: none;
}
}

&.uds-hero-md {
height: $uds-size-spacing-64;
min-height: $uds-size-spacing-64;
}

&.uds-hero-lg {
height: 42.75rem;
min-height: 42.75rem;
}
}

Expand Down